Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] support nested HTMLElements #99

Closed
wants to merge 3 commits into from
Closed

Conversation

HugoDF
Copy link
Collaborator

@HugoDF HugoDF commented Dec 2, 2020

Closes #96

Happy for someone else to PR into this branch.

Todo

  • walk the values when being serialized, generate type/value and mark the object as generated (with __gen: true)
  • [WIP] when receiving the values remove the type/value nesting to display fields correctly
  • add test cases to simulator/example.html x-data (els: [$el], nested: { el: $el, fn() {} })
  • add E2E (Cypress) test for nested HTMLElement/functions
  • (maybe) add unit tests + refactor the whole flattenData thing 😄 (take some sample input/output in the simulator on master and rewrite the function)

@HugoDF HugoDF changed the title [wip] support nested unserializable content [wip] support nested HTMLElements Dec 3, 2020
@HugoDF HugoDF closed this Dec 10, 2020
@HugoDF HugoDF deleted the fix-nested-unserializable branch December 10, 2020 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle arrays and objects containing non-serializable types (HTMLElement & function)
1 participant