ui: Added privacy policy and terms of service link in the footer #1216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuashuai
reviewed
Dec 30, 2024
| Powered by | ||
| {/* eslint-disable-next-line react/jsx-no-target-blank */} | ||
| <a href="https://answer.apache.org" target="_blank"> | ||
| <a |
There was a problem hiding this comment.
- Use the Link component of react-router-dom to replace the a tag.
- Remove target and rel attributes.
shuashuai
reviewed
Dec 30, 2024
| const fullYear = dayjs().format('YYYY'); | ||
| const siteName = siteInfoStore((state) => state.siteInfo.name); | ||
| const cc = `${fullYear} ${siteName}`; | ||
|
|
||
| return ( | ||
| <footer className="bg-light"> | ||
| <Container className="py-3"> | ||
| <p className="text-center mb-0 small text-secondary"> |
There was a problem hiding this comment.
Delete text-secondary in class
|
PR need to be committed to the dev branch. |
|
In fact you don't need to re-submit the PR, you can continue to make changes at this PR. But since you have submitted a new PR, I am closing this PR. Duplicate of #1217 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
/privacy) and "Terms of Service" (/tos) links to the footer, accessible globally.privacy,terms_of_service, andbuild_on) for localization.i18n/en_US.yamlto include the new keys.Testing
Screenshots
Before:
After:
Issue Reference
Closes #1187