Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work towards merging SqlDataReader #2965

Open
MichelZ opened this issue Nov 2, 2024 · 2 comments
Open

Work towards merging SqlDataReader #2965

MichelZ opened this issue Nov 2, 2024 · 2 comments
Labels
Common Project 🚮 Things that relate to the common project project ✔️ Triage Done Issues that are triaged by dev team and are in investigation.

Comments

@MichelZ
Copy link
Contributor

MichelZ commented Nov 2, 2024

Same as #2953 but for SqlDataReader

@edwardneal
Copy link
Contributor

Besides the coding style/comments/CERs, there's other work:

@samsharma2700 samsharma2700 added Common Project 🚮 Things that relate to the common project project ✔️ Triage Done Issues that are triaged by dev team and are in investigation. labels Nov 5, 2024
@edwardneal
Copy link
Contributor

After merging #2967, the diff between netfx and netcore's SqlDataReader implementation is now -407/+159. Most of this is now taken up by two points:

#3042 is a notable style change though. Once that's merged, I can port the exception handling across as time permits (unless someone else wants to pick this up sooner.) I'll submit a port of PR 499 (and any remaining dependencies/post-PR changes.)

The rest of the differences are just differences in logging text and debug assertions, along with ~10 lines of behavioural changes in TrySetMetaData and IsDBNull.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Common Project 🚮 Things that relate to the common project project ✔️ Triage Done Issues that are triaged by dev team and are in investigation.
Projects
None yet
Development

No branches or pull requests

3 participants