#59749 move TrimEnd after path normalization #59753
Open
+1
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Invocation of dotnet-getdocument.dll tool from Microsoft.Extensions.ApiDescription.Server.targets may result in trailing backslash and broken build on Windows
Summary of the changes (Less than 80 chars)
Description
Value of
OpenApiDocumentsDirectory
must be trimmed of trailing backslash on Windows after path normalization.OpenApiDocumentsDirectory = ../foo/
->Path.GetFullPath
(on Windows) -><rooted Path>\foo\
Move
TrimEnd('\')
to after path normalization, as a Linux style directory separator would not be trimmed, translated to windows style backslash by the path normalization done by GetFullPath if build runs on Windows. Resulting value in_DotNetGetDocumentOutputPath
would still have trailing backslash and break the command line (on Windows).There seem to be some changes to this in past commits, moving the TrimEnd around. Looks like a regression.
Fixes #59749 (in this specific format)