Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable signing validation on shipping VMR outputs #4068

Open
Tracked by #3708
mmitche opened this issue Jan 30, 2024 · 5 comments · May be fixed by dotnet/sdk#45836
Open
Tracked by #3708

Enable signing validation on shipping VMR outputs #4068

mmitche opened this issue Jan 30, 2024 · 5 comments · May be fixed by dotnet/sdk#45836
Assignees

Comments

@mmitche
Copy link
Member

mmitche commented Jan 30, 2024

Enable signing validation of VMR build outputs. This may actually be formally covered by https://github.com/dotnet/release/issues/732 in the staging pipeline. Still, it may help to have an interim solution (e..g just running SignCheck over all the binaries to do verification)

Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@ellahathaway
Copy link
Member

T-Shirt Size: XS/S

If this is formally covered by https://github.com/dotnet/release/issues/732 then this is likely as simple as running SignCheck over all the binaries.

@ellahathaway
Copy link
Member

SignCheck does not run on .NET Core, so it's a bit tricky to implement this as a "post-build" step after each repo build. Rather than augment the entire SignCheck tool to work on core, I think that the best approach here would be to validate the produced package artifacts after the final join point.

This test build is an example of what that validation would look like. Note that this validation only checks the artifacts in PackageArtifacts/.

@mmitche mmitche moved this to Ready in .NET Unified Build Jan 6, 2025
@ellahathaway ellahathaway moved this from Ready to In Progress in .NET Unified Build Jan 6, 2025
@ellahathaway
Copy link
Member

ellahathaway commented Jan 6, 2025

@ellahathaway ellahathaway linked a pull request Jan 9, 2025 that will close this issue
@ellahathaway
Copy link
Member

ellahathaway commented Jan 9, 2025

My test runs are failing due to unrelated build issues, so I will have to wait until those are resolved to get a final validation build.

I plan on doing two builds:

  • Build with dry run signing enabled
  • Build with real signing enabled in windows (current state)

The latter build will take a few hours, so best case I'll have final test runs by tomorrow morning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

3 participants