Rebind ModalNotification does not work

[safisa]

Hi,
I am trying to change and add some logic to the showDialog method in the ModalNotification class using rebinding like this:

@injectable()
export class CustomModalNotification extends ModalNotification {
    override showDialog(messageType: MessageType, text: string, options: MainMessageOptions, actions: MainMessageItem[]): Promise<string | undefined> {
        // some new logic...
        return super.showDialog(messageType, text, options, actions);
    }
}

And I have added these lines to the frontend module:

    bind(CustomModalNotification).toSelf().inSingletonScope();
    rebind(ModalNotification).toService(CustomModalNotification);

but it does not take effect, I can see my custom class in the dev tools sources page, but the showDialog is not called from my custom class.
What is wrong with this code?

Thanks

[msujew]

Hey @safisa,

even though ModalNotification is annotated as a @injectable(), all of our modal infrastructure does not use the inversify injection mechanism. They are instead created by using the constructor, making them non-overridable:

theia/packages/plugin-ext/src/main/browser/message-registry-main.ts

Lines 37 to 38 in e27e4d4

	const modalNotification = new ModalNotification();
	return modalNotification.showDialog(messageType, message, options, actions);

You will need to override the caller side in order for your changes to take effect.

[safisa]

Hi,
Ah, I see, the problem is that the only use of this class is in the method above (in your comment), and this class MessageRegistryMainImpl is not injectable!
So, there is no way to override it.

[msujew]

There is actually a way to override it, but not though the normal means of using inversify. I've done this a few times in the past due to the inversify limitation:

MessageRegistryMainImpl.prototype.doShowMessage = (arg1, arg2, ...) => {
   // implement your override in here
};

[safisa]

Thanks @msujew
This worked for me, but as an improvement for the future, it will be nice to make the only one use of the the ModalNotification based on injection...
Thanks again.