Improve bundling for hoisted dependencies #14708
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Closes #14707
This change just sets the
paths
field whenever usingrequire.resolve
to correctly find the hoisted dependencies from the point they are imported.Note that we have a reference to
node-pty
in our generated webpack config that cannot be refactored to userequire.resolve
. If this dependency is not hoisted, the webpack build will fail with a helpful error message.How to test
Use #14481 and replace
"node_modules/trash"
with"packages/filesystem/node_modules/trash"
in your package-lock.json file. Same with other dependencies such as@vscode/ripgrep
,drivelist
or@parcel/watcher
.Review checklist
Reminder for reviewers