New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print warning when deprecated options are configured in config file #19066

Open

ahrtr opened this issue Dec 15, 2024 · 3 comments

Assignees

Labels

good first issue type/feature

Member

ahrtr commented Dec 15, 2024

What would you like to be added?

Please read #18998 (comment)

Why is this needed?

To cover both command line flags and config file

ahrtr added type/feature good first issue labels

jameskim0987 commented Dec 16, 2024

/assign

k8s-ci-robot assigned jameskim0987

Member Author

ahrtr commented Dec 23, 2024

Thanks @jameskim0987 , please feel free to deliver a PR.

mansoor17syed added a commit to mansoor17syed/etcd that referenced this issue


          fix for etcd-io#19066 Print warnings when deprecated options are conf…

810eed4

…igured in config file

mansoor17syed mentioned this issue

fix for #19066 Print warnings when deprecated options are configured in config file #19148

Open

mansoor17syed commented Jan 9, 2025

Hi Team,

I’ve worked on this issue and have sent my changes for review. Could you kindly take a look and provide any feedback or suggestions for improvement?

I noticed the issue was already assigned, but I wanted to give it a try regardless—apologies if this overlaps with ongoing work. I hope my attempt can still be useful.

Looking forward to your feedback!

mansoor17syed added a commit to mansoor17syed/etcd that referenced this issue


          fix for etcd-io#19066 Print warnings when deprecated options are conf…

f5cdee6

…igured in config file

Signed-off-by: mansoora <[email protected]>

mansoor17syed added a commit to mansoor17syed/etcd that referenced this issue


          fix for etcd-io#19066 Print warnings when deprecated options are conf…

af63c8e

…igured in config file

mansoor17syed added a commit to mansoor17syed/etcd that referenced this issue


          fix for etcd-io#19066 Print warnings when deprecated options are conf…

56f54b1

…igured in config file

mansoor17syed added a commit to mansoor17syed/etcd that referenced this issue


          fix for etcd-io#19066 Print warnings when deprecated options are conf…

325221b

…igured in config file

Signed-off-by: mansoora <[email protected]>

mansoor17syed added a commit to mansoor17syed/etcd that referenced this issue


          fix for etcd-io#19066 Print warnings when deprecated options are conf…

b36e444

…igured in config file

Signed-off-by: mansoora <[email protected]>

mansoor17syed added a commit to mansoor17syed/etcd that referenced this issue


          fix for etcd-io#19066 Print warnings when deprecated options are conf…

f929a61

…igured in config file

Signed-off-by: mansoora <[email protected]>

mansoor17syed added a commit to mansoor17syed/etcd that referenced this issue


          fix for etcd-io#19066 Print warnings when deprecated options are conf…

cb56a43

…igured in config file

mansoor17syed added a commit to mansoor17syed/etcd that referenced this issue


          fix for etcd-io#19066 Print warnings when deprecated options are conf…

013c4b7

…igured in config file

mansoor17syed added a commit to mansoor17syed/etcd that referenced this issue


          fix for etcd-io#19066 Print warnings when deprecated options are conf…

f340ceb

…igured in config file

mansoor17syed added a commit to mansoor17syed/etcd that referenced this issue


          fix for etcd-io#19066 Print warnings when deprecated options are conf…

b85a90f

…igured in config file

Signed-off-by: mansoora <[email protected]>

mansoor17syed added a commit to mansoor17syed/etcd that referenced this issue


          fix for etcd-io#19066 Print warnings when deprecated options are conf…

e1acb4d

…igured in config file

Signed-off-by: mansoora <[email protected]>

mansoor17syed added a commit to mansoor17syed/etcd that referenced this issue


          fix for etcd-io#19066 Print warnings when deprecated options are conf…

a156784

…igured in config file

Signed-off-by: mansoora <[email protected]>

mansoor17syed added a commit to mansoor17syed/etcd that referenced this issue


          fix for etcd-io#19066 Print warnings when deprecated options are conf…

3e568cc

…igured in config file

Signed-off-by: mansoora <[email protected]>

mansoor17syed added a commit to mansoor17syed/etcd that referenced this issue


          fix for etcd-io#19066 Print warnings when deprecated options are conf…

f94c1d3

…igured in config file

Signed-off-by: mansoora <[email protected]>

mansoor17syed added a commit to mansoor17syed/etcd that referenced this issue


          fix for etcd-io#19066 Print warnings when deprecated options are conf…

1d4f997

…igured in config file

Signed-off-by: mansoora <[email protected]>

mansoor17syed added a commit to mansoor17syed/etcd that referenced this issue


          fix for etcd-io#19066 Print warnings when deprecated options are conf…

0251fb0

…igured in config file

mansoor17syed added a commit to mansoor17syed/etcd that referenced this issue


          fix for etcd-io#19066 Print warnings when deprecated options are conf…

b1422ee

…igured in config file

Signed-off-by: mansoora <[email protected]>

mansoor17syed added a commit to mansoor17syed/etcd that referenced this issue


          fix for etcd-io#19066 Print warnings when deprecated options are conf…

a8c4d2c

…igured in config file

Signed-off-by: mansoora <[email protected]>

mansoor17syed added a commit to mansoor17syed/etcd that referenced this issue


          fix for etcd-io#19066 Print warnings when deprecated options are conf…

a1d80b2

…igured in config file

Signed-off-by: mansoora <[email protected]>

mansoor17syed added a commit to mansoor17syed/etcd that referenced this issue


          fix for etcd-io#19066 Print warnings when deprecated options are conf…

…igured in config file

Signed-off-by: mansoora <[email protected]>

mansoor17syed added a commit to mansoor17syed/etcd that referenced this issue


          fix for etcd-io#19066 Print warnings when deprecated options are conf…

8f3d5f6

…igured in config file

Signed-off-by: mansoora <[email protected]>

mansoor17syed added a commit to mansoor17syed/etcd that referenced this issue


          fix for etcd-io#19066 Print warnings when deprecated options are conf…

d3c407c

…igured in config file

Signed-off-by: mansoora <[email protected]>

mansoor17syed added a commit to mansoor17syed/etcd that referenced this issue


          fix for etcd-io#19066 Print warnings when deprecated options are conf…

56f09ad

…igured in config file

Signed-off-by: mansoora <[email protected]>

mansoor17syed added a commit to mansoor17syed/etcd that referenced this issue


          fix for etcd-io#19066 Print warnings when deprecated options are conf…

cea1d94

…igured in config file

mansoor17syed added a commit to mansoor17syed/etcd that referenced this issue


          fix for etcd-io#19066 Print warnings when deprecated options are conf…

f532d77

…igured in config file

Signed-off-by: mansoora <[email protected]>

mansoor17syed added a commit to mansoor17syed/etcd that referenced this issue


          fix for etcd-io#19066 Print warnings when deprecated options are conf…

d707796

…igured in config file

Signed-off-by: mansoora <[email protected]>

mansoor17syed added a commit to mansoor17syed/etcd that referenced this issue


          fix for etcd-io#19066 Print warnings when deprecated options are conf…

3bb990f

…igured in config file

Signed-off-by: mansoora <[email protected]>

mansoor17syed added a commit to mansoor17syed/etcd that referenced this issue


          fix for etcd-io#19066 Print warnings when deprecated options are conf…

d3f2f52

…igured in config file

Signed-off-by: mansoora <[email protected]>

mansoor17syed added a commit to mansoor17syed/etcd that referenced this issue


          fix for etcd-io#19066 Print warnings when deprecated options are conf…

91f6153

…igured in config file

Signed-off-by: mansoora <[email protected]>

mansoor17syed added a commit to mansoor17syed/etcd that referenced this issue


          fix for etcd-io#19066 Print warnings when deprecated options are conf…

1c778d2

…igured in config file

Signed-off-by: mansoora <[email protected]>

mansoor17syed added a commit to mansoor17syed/etcd that referenced this issue


          fix for etcd-io#19066 Print warnings when deprecated options are conf…

52ca617

…igured in config file

Signed-off-by: mansoora <[email protected]>

mansoor17syed added a commit to mansoor17syed/etcd that referenced this issue


          fix for etcd-io#19066 Print warnings when deprecated options are conf…

…igured in config file

Signed-off-by: mansoora <[email protected]>

mansoor17syed added a commit to mansoor17syed/etcd that referenced this issue


          fix for etcd-io#19066 Print warnings when deprecated options are conf…

dbc56ea

…igured in config file

mansoor17syed added a commit to mansoor17syed/etcd that referenced this issue


          fix for etcd-io#19066 Print warnings when deprecated options are conf…

98f23c0

…igured in config file

Signed-off-by: mansoora <[email protected]>

mansoor17syed added a commit to mansoor17syed/etcd that referenced this issue


          fix for etcd-io#19066 Print warnings when deprecated options are conf…

ca569f7

…igured in config file

Signed-off-by: mansoora <[email protected]>

mansoor17syed added a commit to mansoor17syed/etcd that referenced this issue


          fix for etcd-io#19066 Print warnings when deprecated options are conf…

2c9a9c0

…igured in config file

Signed-off-by: mansoora <[email protected]>

mansoor17syed added a commit to mansoor17syed/etcd that referenced this issue


          fix for etcd-io#19066 Print warnings when deprecated options are conf…

d1f4692

…igured in config file

Signed-off-by: mansoora <[email protected]>

mansoor17syed added a commit to mansoor17syed/etcd that referenced this issue


          fix for etcd-io#19066 Print warnings when deprecated options are conf…

1c39269

…igured in config file

Signed-off-by: mansoora <[email protected]>

mansoor17syed added a commit to mansoor17syed/etcd that referenced this issue


          fix for etcd-io#19066 Print warnings when deprecated options are conf…

8ccdf8e

…igured in config file

Signed-off-by: mansoora <[email protected]>

mansoor17syed added a commit to mansoor17syed/etcd that referenced this issue


          fix for etcd-io#19066 Print warnings when deprecated options are conf…

31f1bb9

…igured in config file

Signed-off-by: mansoora <[email protected]>

mansoor17syed added a commit to mansoor17syed/etcd that referenced this issue


          fix for etcd-io#19066 Print warnings when deprecated options are conf…

4151dd7

…igured in config file

Signed-off-by: mansoora <[email protected]>

mansoor17syed added a commit to mansoor17syed/etcd that referenced this issue


          fix for etcd-io#19066 Print warnings when deprecated options are conf…

59dc520

…igured in config file

Signed-off-by: mansoora <[email protected]>

mansoor17syed added a commit to mansoor17syed/etcd that referenced this issue


          fix for etcd-io#19066 Print warnings when deprecated options are conf…

126c30a

…igured in config file

Signed-off-by: mansoora <[email protected]>

mansoor17syed added a commit to mansoor17syed/etcd that referenced this issue


          fix for etcd-io#19066 Print warnings when deprecated options are conf…

70b0e50

…igured in config file

Signed-off-by: mansoora <[email protected]>

mansoor17syed added a commit to mansoor17syed/etcd that referenced this issue


          fix for etcd-io#19066 Print warnings when deprecated options are conf…

247ab42

…igured in config file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment