Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New method to access ProviderSectors HAMT from market actor #11997

Open
LexLuthr opened this issue May 15, 2024 · 7 comments
Open

New method to access ProviderSectors HAMT from market actor #11997

LexLuthr opened this issue May 15, 2024 · 7 comments
Labels
good first issue Good for newcomers

Comments

@LexLuthr
Copy link
Contributor

We need a way to access information in https://github.com/filecoin-project/go-state-types/blob/ad909a3d6ebef5ebc5688b4310e954e27da2203b/builtin/v13/market/market_state.go#L66. This can be very useful to verify F05 deals post NV23 if sealer is using ProveCommitSector3 method to commit all sectors.

@LexLuthr
Copy link
Contributor Author

We should have 2 methods:

  1. a list of all sectors[deals] per provider/miner
  2. querying specific deal in a specific sector of a miner.

@rvagg rvagg transferred this issue from filecoin-project/go-state-types May 16, 2024
@rvagg
Copy link
Member

rvagg commented May 16, 2024

@LexLuthr I've moved this to the lotus repo as the API is going to have to be here rather than in go-state-types.

@rjan90 rjan90 added this to FilOz May 16, 2024
@rjan90 rjan90 moved this to 📌 Triage in FilOz May 16, 2024
@LexLuthr
Copy link
Contributor Author

@LexLuthr I've moved this to the lotus repo as the API is going to have to be here rather than in go-state-types.

Thank you. Look forward to have this soon. Along with #11936, we will have all we need to track market deal reliably.

@rjan90 rjan90 moved this from 📌 Triage to 🐱Todo in FilOz May 21, 2024
@beck-8
Copy link
Contributor

beck-8 commented Jun 20, 2024

Will there be any progress here soon?

@rvagg
Copy link
Member

rvagg commented Jun 21, 2024

No, sorry, but it shouldn't be too hard to do. Would someone like to start off by proposing the method signatures and documentation that would slot into api/api_full.go? I can probably tackle it once we have agreement from you (as users) on what we're actually implementing.

@LexLuthr
Copy link
Contributor Author

StateMarketSectorList(ctx, minerAddress) (map[sector number][]abi.DealID, err)
StateMarketSector(ctx, minerAddress, sectorNumber) ([]abi.DealID, err)

I do a confusion here though. If a sector only contains f05 deals, should I assume that []abi.DealID would be in same order as present in physical sector or do we lose the order?
What happens when DDO is in the mix for the above question?

@rvagg
Copy link
Member

rvagg commented Dec 17, 2024

Labelling this good first issue although it's not easy unless you've got some existing experience with the way Lotus plumbs its API pieces together. (Edit: a beginner could definitely pick this up, it's just not super simple, you'd learn a lot in the process but you'd probably need some guidance).

Also related to #12791 so this might help sort that issue out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
Status: 🐱 Todo
Development

No branches or pull requests

3 participants