E2e image sources hard coded

[lentzi90]

/kind bug

What steps did you take and what happened:

I noticed that we have hard coded a few things with the introduction of ORC in the e2e tests. This unfortunately makes the tests much less flexible than they used to be. In theory, we could point to any OpenStack-based cloud, tune the e2e config to match and run the suite.
The images used could differ.

Now with ORC we have hard coded where the images should come from, while still allowing the exact name to be configurable.
This does not make sense to me. We should make the source also configurable.

I think/hope it is already possible to pre-create the images and ORC will just adopt them. This is good.

What did you expect to happen:

It should be possible to run the e2e test suite in different configurations without assumptions on what exact images would be used or where they can be found.

Anything else you would like to add:

I intend to work on this but I don't have an estimate on when I will have the time.

[mdbooth]

This seems reasonable. Sounds like I refactored it too hard when doing this. We just need enough configuration in e2e data to generate the ORC images.

I suspect you'll want to replace the DownloadImage stuff with something more flexible. Note that we don't just create all images on every run. e.g. we only add the upgrade image when running the upgrade test, and the flatcar images when running the flatcar tests.

Just a thought: how about instead of generating these images in code we defined yamls for them. We'd still want to be able to define separate sets of images so we don't load all of them every time, but... maybe a kustomize module per image 'set'? If we put the path to each of these sets in the e2e config, the test could just load them from the specified directory. That way you'd be able to replace them with whatever you need in your environment. Would that work?

[lentzi90]

It does sound doable. We anyway specify the name of each image in the e2e config, so why not point to a kustomization that provides the image 🙂
I think I will slowly get started on this. Just want to get the CI somewhat stable first