Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metrics for SSA cache #10527

Open
sbueringer opened this issue Apr 29, 2024 · 8 comments · May be fixed by #11635
Open

Metrics for SSA cache #10527

sbueringer opened this issue Apr 29, 2024 · 8 comments · May be fixed by #11635
Assignees
@cahillsf
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@sbueringer
Copy link
Member

A while ago we implemented a ssa.Cache to cache SSA calls. I think it would be great if we have corresponding metrics (e.g. cache hit/miss) so we can observe how well the cache is working.

We should at least have labels for:

  • the object of the SSA call (probably just kind)
  • the controller in which the cache is used (MD / MS / cluster topology / ...)

I think we'll have to extend the cache a bit to have the data for the labels.

Also let's take a look at how cache metrics usually look like in the Prometheus format and try to be consistent with that.
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Apr 29, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

CAPI contributors will take a look as soon as possible, apply one of the triage/* labels and provide further guidance.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sbueringer
Copy link
Member Author

(cc @chrischdi as you showed interest in that topic)

@sbueringer sbueringer mentioned this issue Apr 29, 2024
Closed
5 tasks
@fabriziopandini
Copy link
Member

/kind feature
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Apr 30, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 29, 2024
@fabriziopandini fabriziopandini removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 2, 2024
@varshaprasad96 varshaprasad96 mentioned this issue Oct 21, 2024
Open
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 31, 2024
@fabriziopandini fabriziopandini added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Nov 8, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Nov 8, 2024
@cahillsf
Copy link
Member

hey @sbueringer id be interested in opening a PR for this - this is still something that would be helpful right?

@sbueringer
Copy link
Member Author

sbueringer commented Dec 30, 2024 •
edited
Loading

Yes, absolutely! Feel free to go ahead

/assign @cahillsf

@cahillsf cahillsf linked a pull request Jan 2, 2025 that will close this issue
Draft
@cahillsf
Copy link
Member

cahillsf commented Jan 3, 2025

opened up a draft pr and added some comments whenever you have a chance to take a pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cahillsf cahillsf

Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🌱 Add ssh cache metrics cahillsf/cluster-api
5 participants
@sbueringer @fabriziopandini @k8s-ci-robot @cahillsf @k8s-triage-robot