feat(recommender): add round cpu millicores #7682
Conversation
Signed-off-by: Omer Aplatony <[email protected]>
k8s-ci-robot
added
kind/feature
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: omerap12 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/L
Signed-off-by: Omer Aplatony <[email protected]>
|
|
||
| ## CPU Recommendation Rounding | ||
|
|
||
| VPA can now provide CPU recommendations rounded to user-specified values, making it easier to interpret and configure resources. This feature is controlled by the `--round-cpu-millicores` flag in the recommender component. |
There was a problem hiding this comment.
What about removing the "now", or replace it with something like "Since 1.3.0"
| VPA can now provide CPU recommendations rounded to user-specified values, making it easier to interpret and configure resources. This feature is controlled by the `--round-cpu-millicores` flag in the recommender component. | |
| VPA can provide CPU recommendations rounded to user-specified values, making it easier to interpret and configure resources. This feature is controlled by the `--round-cpu-millicores` flag in the recommender component. |
| humanizeMemory = flag.Bool("humanize-memory", false, "Convert memory values in recommendations to the highest appropriate SI unit with up to 2 decimal places for better readability.") | ||
| roundCPUMillicores = flag.Int("round-cpu-millicores", 1, `CPU recommendation rounding factor in millicores. The CPU value will be rounded to the nearest multiple of this factor.`) |
There was a problem hiding this comment.
I'm curious what others think, but I like the idea of these two options being similar.
humanize-memory + humanize-cpu
or
round-memory-mebibyte + round-cpu-millicores
I haven't though through if this is possible or not. So I'm unsure if my idea is a good one or not, but for some reason keeping the options similar just feels like it may be a good user experience.
| @@ -34,4 +34,20 @@ Note: Due to the conversion to binary units and decimal place rounding, the huma | |||
| To enable this feature, set the `--humanize-memory` flag to true when running the VPA recommender: | |||
| ```bash | |||
| --humanize-memory=true | |||
| ``` | |||
|
|
|||
| ## CPU Recommendation Rounding | |||
There was a problem hiding this comment.
+1 for adding docs as the feature is added! This is a habit we need to be getting into
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adds the
--round-cpu-millicoresflag to the VPA recommender, enabling user-configurable rounding of CPU recommendations.Which issue(s) this PR fixes:
Fixes #7678
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: