Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow per-namespace annotations-risk-level #12639

Open
sathieu opened this issue Jan 8, 2025 · 2 comments
Open

Allow per-namespace annotations-risk-level #12639

sathieu opened this issue Jan 8, 2025 · 2 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@sathieu
Copy link
Contributor

sathieu commented Jan 8, 2025

Raising annotations-risk-level to High is good, but we need a way to add exceptions for specific namespaces that we now are using safe parameters.

For example, we use this for MinIO:

      nginx.ingress.kubernetes.io/configuration-snippet: |
          chunked_transfer_encoding off;

Proposed change: add a new option in ConfigMap annotations-risk-level-excluded-namespaces containing a space-separed list of namespaces where annotations-risk-level is set to Critical.

@sathieu sathieu added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 8, 2025
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jan 8, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sathieu
Copy link
Contributor Author

sathieu commented Jan 8, 2025

Other usecases (for kube-apiserver):

    nginx.ingress.kubernetes.io/server-snippet: |
      client_header_buffer_size 40k;
      large_client_header_buffers 4 40k;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
Development

No branches or pull requests

2 participants