Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorder ValidatingAdmissionPolicy components for logical flow #49176

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Reorder ValidatingAdmissionPolicy components for logical flow #49176

merged 1 commit into from
Jan 10, 2025

Conversation

tancheng33
Copy link
Contributor

@tancheng33 tancheng33 commented Dec 20, 2024 •
edited
Loading

Description

Reorder the bullet points in the "What Resources Make a Policy" section of the Validating Admission Policy documentation to improve logical flow. Previously, the ValidatingAdmissionPolicyBinding was described as linking "the above resources" when only one resource had been mentioned. This change puts the parameter resource description before the binding, making the documentation more accurate and easier to understand.

The change reorders the components as follows:

  1. ValidatingAdmissionPolicy (abstract logic)
  2. Parameter resource (concrete configuration)
  3. ValidatingAdmissionPolicyBinding (links the above two resources)

Issue

Closes: #49136

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

CLA Missing ID CLA Not Signed

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Dec 20, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @tancheng33!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot requested a review from cici37 December 20, 2024 01:44
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Dec 20, 2024
@k8s-ci-robot k8s-ci-robot requested a review from jpbetz December 20, 2024 01:44
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 20, 2024
@netlify Netlify
Copy link

netlify bot commented Dec 20, 2024

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 212637c
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6764cbf4e3c6570008d3354e
😎 Deploy Preview https://deploy-preview-49176--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 20, 2024
sftim
sftim reviewed Jan 10, 2025
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 10, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6627aec676f5082ca45d9893e84d4069634d09f5

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2025
@k8s-ci-robot k8s-ci-robot merged commit 5d3b9c3 into kubernetes:main Jan 10, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@cici37 cici37 Awaiting requested review from cici37

@jpbetz jpbetz Awaiting requested review from jpbetz

Assignees

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect details in ValidatingAdmissionPolicy docs
3 participants
@tancheng33 @k8s-ci-robot @sftim