Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Plugin: LineEndingCheck: Use GitPython #1250

Open
Javagedes opened this issue Jan 8, 2025 · 0 comments
Open

[Feature]: Plugin: LineEndingCheck: Use GitPython #1250

Javagedes opened this issue Jan 8, 2025 · 0 comments
Labels
state:needs-triage Needs to triaged to determine next steps type:feature-request A new feature proposal urgency:low Little to no impact

Comments

@Javagedes
Copy link
Contributor

Feature Overview

GitPython was adopted by edk2-pytool-extensions, and per the documentation in the LineEndingCheck plugin, we can switch the current git shell commands for GitPython

    # Note: This function currently accesses git via the git command to prevent
    #       introducing a new Python git module dependency in mu_basecore
    #       on gitpython.
    #
    #       After gitpython is adopted by edk2-pytool-extensions, this
    #       implementation can be updated to use the gitpython interface.

Solution Overview

Switch the LineEndingCheck plugin from running raw shell commands to using a well-maintained library (GitPython) instead. Possibly evaluate if any other plugins use raw git commands and switch them to GitPython also.

Alternatives Considered

No response

Urgency

Low

Are you going to implement the feature request?

I will implement the feature

Do you need maintainer feedback?

No maintainer feedback needed

Anything else?

No response

@Javagedes Javagedes added state:needs-triage Needs to triaged to determine next steps type:feature-request A new feature proposal labels Jan 8, 2025
@github-actions github-actions bot added the urgency:low Little to no impact label Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:needs-triage Needs to triaged to determine next steps type:feature-request A new feature proposal urgency:low Little to no impact
Projects
None yet
Development

No branches or pull requests

1 participant