Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Avoid repeating fix action names in PR-action workflow #5894

Open
chalin opened this issue Jan 7, 2025 · 0 comments
Open

[CI] Avoid repeating fix action names in PR-action workflow #5894

chalin opened this issue Jan 7, 2025 · 0 comments
Labels
CI/infra CI & infrastructure

Comments

@chalin
Copy link
Contributor

chalin commented Jan 7, 2025

Currently, the PR-action workflow explicitly lists /fix action names. We should keep things DRY and instead check via:

$ npm run -s _list:fix:\*
  fix:dict
  fix:expired
  fix:filenames
  fix:format
  fix:htmltest-config
  fix:i18n
  fix:markdown
  fix:refcache
  fix:submodule
  fix:text

Though that would probably require something like renaming fix:refcache:refresh to a direct fix argument, such as fix:refcache-refresh. Such an approach would avoid script-name mismatches as what occurred in https://github.com/open-telemetry/opentelemetry.io/actions/runs/12654515860/job/35262586821.

@chalin chalin added the CI/infra CI & infrastructure label Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/infra CI & infrastructure
Projects
Status: No status
Development

No branches or pull requests

1 participant