Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The action uses the soon deprecated set-output command #151

Closed
pcaversaccio opened this issue Nov 1, 2023 · 5 comments
Closed

The action uses the soon deprecated set-output command #151

pcaversaccio opened this issue Nov 1, 2023 · 5 comments
Labels
help wanted Extra attention is needed question Further information is requested

Comments

@pcaversaccio
Copy link

Example warning here:

Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Would appreciate if you could update the action accordingly.

@zgosalvez
Copy link
Owner

This is already using 1.10 of actions/core. The warning is caused by backward compatibility. See actions/toolkit#1336.

@zgosalvez zgosalvez closed this as not planned Won't fix, can't repro, duplicate, stale Nov 2, 2023
@pcaversaccio
Copy link
Author

Thx for the link. So it seems as this action somehow evaluates GITHUB_OUTPUT to empty? See comment here.

@zgosalvez
Copy link
Owner

Adding a little bit more context for future reference: actions/toolkit#1218 (comment) as GITHUB_OUTPUT is indeed not set. However, I'm not doing anything special in this action as I am setting output values as per current docs using the official @actions/core package:

I'll re-open this issue for future visibility. Thank you!

@zgosalvez zgosalvez reopened this Nov 2, 2023
@zgosalvez zgosalvez added help wanted Extra attention is needed question Further information is requested labels Nov 2, 2023
@pcaversaccio
Copy link
Author

Very interesting - maybe their docs are slightly outdated? I'm not a GitHub Actions expert tbh; maybe you can ask this question in the actions/toolkit repository since I assume others are also affected by this issue?

@pcaversaccio
Copy link
Author

good news @zgosalvez, by bumping the zgosalvez/github-actions-report-lcov action to v4 the warning disappeared. I will close this issue accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants