feat: Validator deadline for reexecution #11050
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalladino
force-pushed
the
palla/validator-reexec-timeout
branch
from
3d9c959 to
f5a6f2f
Compare
spalladino
force-pushed
the
palla/validate-with-iterator
branch
2 times, most recently
from
d1e640d to
2caec75
Compare
spalladino
force-pushed
the
palla/validator-reexec-timeout
branch
from
f5a6f2f to
e48a0d2
Compare
spalladino
force-pushed
the
palla/validate-with-iterator
branch
from
83affff to
b887301
Compare
spalladino
force-pushed
the
palla/validator-reexec-timeout
branch
from
746c2ea to
1d9b16a
Compare
spalladino
commented
Jan 7, 2025
Comment on lines
+524
to
+531
| // When building a block as a proposer, we set the deadline for tx processing to the start of the | ||
| // CREATING_BLOCK phase, plus the expected time for tx processing. When validating, we start counting | ||
| // the time for tx processing from the start of the COLLECTING_ATTESTATIONS phase plus the attestation | ||
| // propagation time. See the comments in setTimeTable for more details. | ||
| const processingEndTimeWithinSlot = opts.validateOnly | ||
| ? this.timeTable[SequencerState.COLLECTING_ATTESTATIONS] + this.attestationPropagationTime + this.processTxTime | ||
| : this.timeTable[SequencerState.CREATING_BLOCK] + this.processTxTime; | ||
|
|
There was a problem hiding this comment.
This is the only actual change for this feature.
Adds a reexecution deadline for validators, so they abort trying to reexecute public txs while block building if too late into the slot. Fixes #10959
spalladino
force-pushed
the
palla/validator-reexec-timeout
branch
from
71d4f0a to
94741b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a reexecution deadline for validators, so they abort trying to reexecute public txs while block building if too late into the slot.
As part of this PR, we are adding a hook to tweak logger module names (so we can inject an id when running multiple components in the same process), and extracting the chain monitor from the e2e epochs test.
Fixes #10959