Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement subscription IDs #2954

Merged
merged 6 commits into from
Jan 10, 2025
Merged

feat: implement subscription IDs #2954

merged 6 commits into from
Jan 10, 2025

Conversation

OrKoN
Copy link
Collaborator

@OrKoN OrKoN commented Jan 7, 2025

This PR implements refactoring to support subscription IDs. In-scope:

  • Internal refactoring to align with the spec.
  • Generation of subscription IDs.

To be addressed in follow-ups:

  • unsubscribe by IDs
  • unit tests should not assert only channels but the entire subscription struct.

Notable changes:

  • removal of subscribe priority (the insertion order reflects the priority).
  • fix in findTopLevelBrowsingContext to not return an id for non-existing contexts.
  • clearer way to handle global events (that are not related to any given context).
  • checks like isSubscribed should use specific events instead of module event names.

@OrKoN OrKoN mentioned this pull request Jan 7, 2025
2 tasks
@OrKoN OrKoN force-pushed the orkon/subscription-ids branch 22 times, most recently from 5a69cf2 to 4674bde Compare January 8, 2025 16:29
@OrKoN OrKoN added puppeteer Run Puppeteer test when added to PR and removed puppeteer Run Puppeteer test when added to PR labels Jan 8, 2025
@OrKoN OrKoN force-pushed the orkon/subscription-ids branch 4 times, most recently from ab747a2 to fcfa942 Compare January 9, 2025 09:03
@OrKoN OrKoN marked this pull request as ready for review January 9, 2025 09:17
@OrKoN OrKoN force-pushed the orkon/subscription-ids branch from 4c3d011 to 8b92d8f Compare January 9, 2025 16:10
@OrKoN OrKoN force-pushed the orkon/subscription-ids branch 8 times, most recently from a04f6f3 to 8ebbb14 Compare January 10, 2025 08:30
@sadym-chromium sadym-chromium added the puppeteer Run Puppeteer test when added to PR label Jan 10, 2025
@OrKoN OrKoN force-pushed the orkon/subscription-ids branch from ed9174a to 879ab57 Compare January 10, 2025 09:33
@OrKoN OrKoN removed the puppeteer Run Puppeteer test when added to PR label Jan 10, 2025
@OrKoN OrKoN merged commit 23642a4 into main Jan 10, 2025
53 checks passed
@OrKoN OrKoN deleted the orkon/subscription-ids branch January 10, 2025 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants