Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add postinstall support for brew and cask #1555

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Add postinstall support for brew and cask #1555

merged 1 commit into from
Jan 10, 2025

Conversation

MikeMcQuaid
Copy link
Member

This allows postinstall to be used to run a command after a formula or cask is installed.

While we're here, also adjust the restart_service behaviour to correctly match the comment i.e. require always to restart every time and otherwise just restart on an install or upgrade of a formula.

@MikeMcQuaid MikeMcQuaid force-pushed the postinstall branch 2 times, most recently from 5525de6 to 874600a Compare January 9, 2025 15:38
@MikeMcQuaid MikeMcQuaid marked this pull request as ready for review January 9, 2025 15:38
@MikeMcQuaid MikeMcQuaid requested review from Bo98 and carlocab January 9, 2025 15:39
spec/bundle/brew_installer_spec.rb Show resolved Hide resolved
lib/bundle/brew_installer.rb Show resolved Hide resolved
This allows `postinstall` to be used to run a command after a formula
or cask is installed.

While we're here, also adjust the `restart_service` behaviour to
correctly match the comment i.e. require `always` to restart every
time and otherwise just restart on an install or upgrade of a formula.
README.md Show resolved Hide resolved
Copy link
Member

@colindean colindean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm very excited for this ❤️

@MikeMcQuaid MikeMcQuaid merged commit f035015 into master Jan 10, 2025
5 checks passed
@MikeMcQuaid MikeMcQuaid deleted the postinstall branch January 10, 2025 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants