Add srcset and sizes in content with a filter
#177
Merged
+184
−121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 22, 2015
Closed
This changes our approach from one where `srcset` and `sizes` are written to the image markup in post content to one where the responsive attributes are added on the front end when the page is being rendered. There is a small performance hit but the benefit is worth the tradeoff for what is gained. What exactly do we gain? Glad you asked: * Automatically extend support to images in posts published before we responsive image support was available. * Removes the need to update the markup in TinyMCE when the image size is changed. * Keeps `sizes` attributes, which should probably be adjusted based on the needs of the theme, from being stored in the database. * Is non-destructive if a site needs to change available image sizes and regenerate thumbnails. Changes: * Removes the old JS code for handling markup changes in TinyMCE * Adds `tevkori_filter_content_images()` as a display filter. * Adds `_tevkori_filter_content_images_callback()` to process filtered images. * Adds tests
joemcgill
force-pushed
the
content-filter-a
branch
from
63f5156 to
84bc9ee
Compare
|
I replaced the |
joemcgill
added a commit
that referenced
this pull request
Sep 23, 2015
Add `srcset` and `sizes` in content with a filter
This was referenced Sep 23, 2015
| $uploads_dir = wp_upload_dir(); | ||
| $path_to_upload_dir = $uploads_dir['baseurl']; | ||
|
|
||
| $content = preg_replace_callback( '|<img ([^>]+' . $path_to_upload_dir . '[^>]+)[\s?][\/?]>|i', '_tevkori_filter_content_images_callback', $content ); |
There was a problem hiding this comment.
I am not sure but when I look at this regex it appears to me that the first group will contain everything up to the first > that it finds. So if there is a space and slash before the closing tag, it will be included.
Shouldn't we remove [\s?][\/?] and then change line 418 from
$image_html = "<img " . $atts . " " . $srcset . " " . $sizes . " />";
to
$image_html = "<img $srcset . " " . $sizes . " " . $atts . ">";
?
The space and the slash will be part of $atts.
Or am I wrong?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes our approach from one where
srcsetandsizesare written to theimage markup in post content to one where the responsive attributes are added on the
front end when the page is being rendered. There is a small performance hit but the
benefit is worth the tradeoff for what is gained. What exactly do we gain? Glad you
asked:
support was available.
sizesattributes, which should probably be adjusted based on the needs of thetheme, from being stored in the database.
thumbnails.
Changes:
tevkori_filter_content_images()as a display filter._tevkori_filter_content_images_callback()to process filtered images.Props @jaspermdegroot, @peterwilsoncc
Related: #170
Replaces: #175
Resolves: #83