HOFF-1059: fix functional test failing in GitHub workflow

[Rhodine-orleans-lindsay]

What?

Fix Hof automated functional test failing on GitHub Actions - HOFF-1059

Why?

• Hof has automated workflows that run different jobs including tests when a branch is pushed to GitHub. The job that runs HOF tests is failing on the functional tests which is preventing the completion of checks.
• Between December 5th and January 17th, there was a rollout for an update to the ubuntu operating system that the GitHub workflow is running on (See here - Ubuntu-latest workflows will use Ubuntu-24.04 image actions/runner-images#10636). As our workflow is set to run on 'ubuntu-latest' by default, it picked up the recently updated version but this is causing our functional test to break (See image in description for error log).

How?

Per the guidance in the link above I will rollback our ubuntu version and set it to 22.04 which will still be supported for 2 more years.

Testing?

Workflow tests now passing

Screenshots (optional)

Anything Else? (optional)

• I have updated the node version the workflow runs from 14 to 20 as 14 is no longer supported and our services are updated to 20
• I have updated the GitHub actions versions to the latest (version 4)
• I have renamed the pr template so it can be generated automatically on pr creation. I also amend one of the checklist points from checking for green drone builds to passing workflow jobs as hof doesn't build on drone.

Check list

• I have reviewed my own pull request for linting issues (e.g. adding new lines)
• I have written tests (if relevant) - N/A
• I have created a JIRA number for my branch
• I have created a JIRA number for my commit
• I have followed the chris beams method for my commit https://cbea.ms/git-commit/
  here is an example commit
• Ensure workflow jobs are passing especially tests
• I will squash the commits before merging

[Adesh-Ramchurn]

Hi @Rhodine-orleans-lindsay just a small comment, there are some tests that are being skipped. Are they required?

[Rhodine-orleans-lindsay]

Hi @Rhodine-orleans-lindsay just a small comment, there are some tests that are being skipped. Are they required?

Hi @Adesh-Ramchurn, no they are not required here. Those are auto-tags for versioning which only run on the master branch - see

hof/.github/workflows/automate-tag.yml

Line 48 in 977f7bf

startsWith(github.ref, 'refs/heads/master') &&

[Adesh-Ramchurn]

Thanks for clarifying that Rhodine. Code looks good