Implement support for the free-threaded build of CPython 3.13 #84
Conversation
psf-chronographer
bot
added
the
bot:chronographer:provided
| @@ -241,6 +242,14 @@ jobs: | |||
| uses: py-actions/py-dependency-install@v4 | |||
| with: | |||
| path: requirements/test.txt | |||
| - name: Install Cython nightly on free-threading | |||
There was a problem hiding this comment.
I assume this can also be removed once Cython 3.1 is out? Can we get a TODO comment here as well.
There was a problem hiding this comment.
Actually, will 3.1.0a1 work? Would probably simplify some of this, as that's already on PyPI.
There was a problem hiding this comment.
Wasn't this the one that broke yarl during the sprints?
There was a problem hiding this comment.
Yes. I think it's unlikely that we would hit that issue though, at least in this code base.
There was a problem hiding this comment.
3.1.0a1 would work sufficiently well, though there's many Cython improvements that are being currently worked on and will appear in the nightlies much sooner. I can do whatever people think is best.
There was a problem hiding this comment.
I think to ease future maintenance, it'd be best to use a released version so we don't need to update this again later and can keep it simple. If there's major improvements we want, we can probably just ask them for another alpha release.
There was a problem hiding this comment.
Sure! Keep in mind that Cython doesn't really do many releases though.
pyproject.toml
Outdated
| [[tool.cibuildwheel.overrides]] | ||
| select = "cp313t-*" | ||
| build-frontend = "build; args: --no-isolation" | ||
| before-build = "bash {package}/scripts/cibw_before_build.sh" | ||
|
|
There was a problem hiding this comment.
Also another comment here, I'm unclear if only the before-build line or other lines should be removed when Cython 3.1 is out.
There was a problem hiding this comment.
Isn't this a list? Perhaps, the script could be stuffed right inside this config?
There was a problem hiding this comment.
Isn't this a list? Perhaps, the script could be stuffed right inside this config?
Not sure whether that would work cross-platform, but I can try it if you want.
| @@ -1,4 +1,4 @@ | |||
| # cython: language_level=3 | |||
| # cython: language_level=3, freethreading_compatible=True | |||
There was a problem hiding this comment.
I think this can go into pyproject.toml. There's a section for Cython.
There was a problem hiding this comment.
I tried that but it unfortunately cannot, because there's not the ability to add a version-specific option to pyproject.toml. For this, the build backend would have to be changed, which seems like a bigger hassle.
| FREE_THREADED_BUILD="$(python -c"import sysconfig; print(bool(sysconfig.get_config_var('Py_GIL_DISABLED')))")" | ||
| if [[ $FREE_THREADED_BUILD == "True" ]]; then | ||
| python -m pip install -U pip | ||
| python -m pip install -i https://pypi.anaconda.org/scientific-python-nightly-wheels/simple cython |
There was a problem hiding this comment.
This should be possible to implement less intrusively though PIP_CONSTRAINT and Cython @ url syntax in the constraint file..
There was a problem hiding this comment.
That would mean that we install a nightly Cython for non-free-threaded Pythons as well though, which to me seems suboptimal. What do you think?
|
Hey folks, thanks for all the review and sorry for the extended delay here, I was out on PTO. I've addressed most of the comments around adding some TODOs and replied to the rest. |
What do these changes do?
Are there changes in behavior for the user?
No.
Related issue number
Checklist