Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests | Activate SplitPacket Tests #3061

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

MichelZ
Copy link
Contributor

@MichelZ MichelZ commented Dec 5, 2024

AI Blurp

This pull request includes several improvements and refactorings to the SplitPacketTest class and the DataTestUtility class in the Microsoft.Data.SqlClient test suite. The most important changes include adding new utility methods, refactoring existing methods, and enhancing the test class with proper resource disposal.

Improvements and refactorings:

Enhancements to test class:

These changes enhance the code readability, maintainability, and ensure that resources are properly managed during the tests.

Human stuff

This removes the ActiveIssue 5538 from the SplitPacketTest
It makes sure that the test is only run on localhost and without named instances due to the fact that the tests are proxying the requests.

Also added IDisposable cleanup so that the started threads don't hang around.

@MichelZ
Copy link
Contributor Author

MichelZ commented Dec 5, 2024

/azp run

Copy link

Commenter does not have sufficient privileges for PR 3061 in repo dotnet/SqlClient

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant