Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge | Cleanup Pre 2005 Support in TdsParser #3085

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

MichelZ
Copy link
Contributor

@MichelZ MichelZ commented Dec 18, 2024

Now that #2839 is merged, the Pre 2005 Code can be removed from netfx to align netfx & netcore code for future merge of TdsParser.

It also removes asserts that were used to gate 2005-only code

The code does not aim to remove Pre 2005 Code from other classes

This is working towards #2953

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 57.81250% with 54 lines in your changes missing coverage. Please review.

Project coverage is 72.75%. Comparing base (986cdb9) to head (b9a0e05).

Files with missing lines Patch % Lines
...nt/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs 56.80% 54 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3085      +/-   ##
==========================================
+ Coverage   72.74%   72.75%   +0.01%     
==========================================
  Files         283      283              
  Lines       58968    58883      -85     
==========================================
- Hits        42894    42839      -55     
+ Misses      16074    16044      -30     
Flag Coverage Δ
addons 92.58% <ø> (ø)
netcore 75.51% <100.00%> (+0.02%) ⬆️
netfx 71.21% <56.80%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edwardneal
Copy link
Contributor

Looks good to me. Once this PR's merged, I've got a branch ready to submit (diff - about half the size of this PR) which chases the references to TdsParser.Is2005OrNewer and SqlLoginAck.isVersion8 and removes the now-redundant code.

@mdaigle mdaigle added this to the 7.0-preview1 milestone Jan 7, 2025
@mdaigle mdaigle requested a review from a team January 7, 2025 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants