Use the latest available jdk #59788

ViktorHofer · 2025-01-09T07:54:45Z

dotnet-policy-service · 2025-01-09T07:55:03Z

Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at.

ViktorHofer · 2025-01-09T12:57:46Z

@wtgodbe @BrennanConroy this will fix your builds (everything is broken right now). I opened dotnet/source-build#4816 to track how to best handle this going forward, including your local script to install a jdk.

We patched the VMR with this change to unblock builds.

wtgodbe · 2025-01-09T20:48:44Z

global.json

@@ -24,7 +24,7 @@
    "xcopy-msbuild": "17.8.5"
  },
  "native-tools": {
-    "jdk": "11.0.24"
+    "jdk": "latest"


This would break

aspnetcore/eng/scripts/InstallJdk.ps1

Lines 24 to 27 in e0e0224

if (-not $JdkVersion) {

$globalJson = Get-Content "$repoRoot\global.json" | ConvertFrom-Json

$JdkVersion = $globalJson.'native-tools'.jdk

}

when we don't pass in a version - @BrennanConroy @halter73 maybe we could just default to https://aka.ms/download-jdk/microsoft-jdk-11.0.25-windows-x64.zip for now?

Since we're likely changing the mechanism, let's just do whatever is needed to get this working.

@ViktorHofer can you just change the block I linked to default to 11.0.24 for now?

@wtgodbe feel free to push into this branch

OK I think I got it right.

wtgodbe · 2025-01-09T21:19:51Z

Whoa, github AI automatically populated an accurate commit description for my commit. Neat

BrennanConroy · 2025-01-09T22:48:03Z

src/SignalR/clients/java/signalr/build.gradle

@@ -22,7 +22,7 @@ allprojects {
    version project.findProperty('packageVersion') ?: "99.99.99-dev"

    java {
-        sourceCompatibility = 1.8
+        sourceCompatibility = 1.9


Why was this changed?

invalid source release: 9

See dotnet/sdk#45822 (comment)

We started hitting an error w/ version 8 when updating to 11.0.25:

EXEC : error : [options] source value 8 is obsolete and will be removed in a future release [D:\a\_work\1\vmr\src\aspnetcore\src\SignalR\clients\java\signalr\core\signalr.client.java.core.javaproj]

I'm not sure how to proceed if the underlying machines are in a mixed state, as they seem to be (some have 11.0.24, which is incompatible w/ 9, and some have 11.0.25, which is incompatible w/ 8)

Oh, never mind, it's Helix, not the build machines. Do you know why non-windows is on JDK 10 & windows is on 11 here? The Helix failure was only on Mac.

aspnetcore/eng/targets/Helix.targets

Lines 3 to 4 in e0e0224

<HelixPreCommand Condition="'$(IsWindowsHelixQueue)' == 'true'" Include="call RunPowershell.cmd InstallJdk.ps1 11.0.3 %25HELIX_CORRELATION_PAYLOAD%25\jdk && set %22JAVA_HOME=%25HELIX_CORRELATION_PAYLOAD%25\jdk%22" />

<HelixPreCommand Condition="'$(IsWindowsHelixQueue)' != 'true' AND '$(IsMacHelixQueue)' != 'true'" Include="./installjdk.sh 10.0.2 x64 && if [ "%24JAVA_HOME" = "" ]%3B then export JAVA_HOME=%24PWD/java%3B fi" />

I thought all machines were supposed to have moved to 21.X?

Probably should remove those lines now? Wonder if we used to have to install the jdk ourselves 5 years ago.

Oh, I totally missed that. So it looks like whatever version of macos-openjdk is pre-installed on the MacOS-13 queue isn't compatible w/ 1.9. @dotnet/dnceng does anyone know how we can check what version is installed on OSX.13.amd64.open? helix.dot.net doesn't list one.

Related to this ask?

dotnet/dnceng#4554

all macOS machines will have OpenJDK 8 and 21 after they are next refreshed

So maybe the machines haven't been refreshed?

Now we have

ERROR: JAVA_HOME is not set and no 'java' command could be found in your PATH.

On Windows 🙄

Should probably revert 3b86147

Use the latest available jdk

6f55fd1

dotnet-issue-labeler bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jan 9, 2025

ViktorHofer added 2 commits January 9, 2025 10:56

Specify toolchain in build.gradle files

3a3c11b

Try something else

ddd67f0

ViktorHofer mentioned this pull request Jan 9, 2025

Use latest jdk available in VMR aspnetcore build dotnet/sdk#45822

Merged

ViktorHofer marked this pull request as ready for review January 9, 2025 12:57

ViktorHofer requested review from BrennanConroy, halter73, wtgodbe and a team as code owners January 9, 2025 12:57

wtgodbe mentioned this pull request Jan 9, 2025

Update java to 11.0.25 #59794

Closed

wtgodbe reviewed Jan 9, 2025

View reviewed changes

ViktorHofer and others added 2 commits January 9, 2025 22:17

Update InstallJdk.ps1

6fb3e6b

Remove unused variable $globalJson in InstallJdk.ps1

0ff7224

wtgodbe approved these changes Jan 9, 2025

View reviewed changes

halter73 approved these changes Jan 9, 2025

View reviewed changes

wtgodbe enabled auto-merge (squash) January 9, 2025 21:21

BrennanConroy reviewed Jan 9, 2025

View reviewed changes

wtgodbe and others added 3 commits January 9, 2025 15:23

Update Helix.targets

3b86147

Update GsonHubProtocolTest.java

2e2bd77

Update Helix.targets

fca0103

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use the latest available jdk #59788

Use the latest available jdk #59788

ViktorHofer commented Jan 9, 2025 •

edited

Loading

dotnet-policy-service bot commented Jan 9, 2025

ViktorHofer commented Jan 9, 2025 •

edited

Loading

wtgodbe Jan 9, 2025

BrennanConroy Jan 9, 2025

wtgodbe Jan 9, 2025

ViktorHofer Jan 9, 2025

ViktorHofer Jan 9, 2025

wtgodbe commented Jan 9, 2025 •

edited

Loading

BrennanConroy Jan 9, 2025

wtgodbe Jan 9, 2025

wtgodbe Jan 9, 2025

BrennanConroy Jan 9, 2025

BrennanConroy Jan 9, 2025

wtgodbe Jan 9, 2025 •

edited

Loading

sebastienros Jan 9, 2025

BrennanConroy Jan 9, 2025

BrennanConroy Jan 10, 2025

wtgodbe Jan 10, 2025

	if (-not $JdkVersion) {
	$globalJson = Get-Content "$repoRoot\global.json" \| ConvertFrom-Json
	$JdkVersion = $globalJson.'native-tools'.jdk
	}

	<HelixPreCommand Condition="'$(IsWindowsHelixQueue)' == 'true'" Include="call RunPowershell.cmd InstallJdk.ps1 11.0.3 %25HELIX_CORRELATION_PAYLOAD%25\jdk && set %22JAVA_HOME=%25HELIX_CORRELATION_PAYLOAD%25\jdk%22" />
	<HelixPreCommand Condition="'$(IsWindowsHelixQueue)' != 'true' AND '$(IsMacHelixQueue)' != 'true'" Include="./installjdk.sh 10.0.2 x64 && if [ "%24JAVA_HOME" = "" ]%3B then export JAVA_HOME=%24PWD/java%3B fi" />

Use the latest available jdk #59788

Are you sure you want to change the base?

Use the latest available jdk #59788

Conversation

ViktorHofer commented Jan 9, 2025 • edited Loading

dotnet-policy-service bot commented Jan 9, 2025

ViktorHofer commented Jan 9, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wtgodbe commented Jan 9, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wtgodbe Jan 9, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ViktorHofer commented Jan 9, 2025 •

edited

Loading

ViktorHofer commented Jan 9, 2025 •

edited

Loading

wtgodbe commented Jan 9, 2025 •

edited

Loading

wtgodbe Jan 9, 2025 •

edited

Loading