Make cdac APIs public but experimental #111180
Open
+175
−175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @tommcdon |
max-charlamb
reviewed
Jan 8, 2025
| { | ||
| internal TypeHandle(TargetPointer address) | ||
| public TypeHandle(TargetPointer address) |
There was a problem hiding this comment.
Should we keep these (TypeHandle, MethodDescHandle, ModuleHandle,...) constructors internal?
These data structures should only be created by contracts (and test mocking).
There was a problem hiding this comment.
That makes sense. I'll switch these to internal.
There was a problem hiding this comment.
So I looked into this more and we can't make them internal as our layering has these types defined in the .Abstractions assembly and the actual contract implementations are in a different assembly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the cdac APIs public but experimental to make them easier to experiment with in other projects while we are still stabilizing the API surface.
Any usages outside of the cdac folder (or outside the repo entirely) will need to actively opt-in to using these APIs by suppressing the warning from the Experimental attribute.
Also address feedback from analyzers that kicked in as soon as I removed all of the IVT attributes. Keep the IVT for the tests though as they use a lot of "internal" types.
I've tried to limit the public API surface to the contract abstractions and the contract factories, at least as a starting baseline. I did make public all types used in the SOS-Dac interface implementation.