Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WASM][ST] trim more MT code #111214

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[WASM][ST] trim more MT code #111214

wants to merge 2 commits into from
+241 −142

Conversation

pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Jan 8, 2025 •
edited
Loading

Motivation: smaller and more deterministic code for single-threaded applications.

  • throw PlatformNotSupportedException when not IsThreadStartSupported so that we trim more code.
    • It would throw anyway later. This way the linker understand it can trim rest of the implementation.
  • simplify LowLevelLock for ST
  • SpinCountforSpinBeforeWait = 0
  • added FEATURE_SINGLE_THREAD define constant

This PR makes calls to .Wait throw earlier and more consistently

@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-VM-threading-mono labels Jan 8, 2025
@pavelsavara pavelsavara added this to the 10.0.0 milestone Jan 8, 2025
@pavelsavara pavelsavara self-assigned this Jan 8, 2025
@pavelsavara pavelsavara added the size-reduction Issues impacting final app size primary for size sensitive workloads label Jan 8, 2025
This was referenced Jan 8, 2025
Open
Open
@pavelsavara pavelsavara closed this Jan 9, 2025
@pavelsavara pavelsavara reopened this Jan 9, 2025
@pavelsavara pavelsavara changed the title [browser][ST] trim more MT code [WASM][ST] trim more MT code Jan 9, 2025
This was referenced Jan 9, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lewing lewing Awaiting requested review from lewing lewing will be requested when the pull request is marked ready for review lewing is a code owner

@steveisok steveisok Awaiting requested review from steveisok steveisok will be requested when the pull request is marked ready for review steveisok is a code owner

@vitek-karas vitek-karas Awaiting requested review from vitek-karas vitek-karas will be requested when the pull request is marked ready for review vitek-karas is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@pavelsavara pavelsavara

Labels
arch-wasm WebAssembly architecture area-VM-threading-mono size-reduction Issues impacting final app size primary for size sensitive workloads
Projects
None yet
Milestone
10.0.0
Development

Successfully merging this pull request may close these issues.
1 participant
@pavelsavara