Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rafthttp: Improve warn message in checkClusterCompatibilityFromHeader #19112

Merged
merged 3 commits into from
Jan 10, 2025

Conversation

aladesawe
Copy link
Contributor

@aladesawe aladesawe commented Dec 27, 2024

@k8s-ci-robot
Copy link

Hi @aladesawe. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@aladesawe aladesawe changed the title Update misleading warn message when checkClusterCompatibilityFromHeader finds a mismatch rafthttp: Update misleading warn message when checkClusterCompatibilityFromHeader finds a mismatch Dec 27, 2024
@aladesawe
Copy link
Contributor Author

@ivanvc I stumbled on this misleading message. Please let me know if an issue should be created to update this.

@aladesawe aladesawe changed the title rafthttp: Update misleading warn message when checkClusterCompatibilityFromHeader finds a mismatch rafthttp: Update typo in warn message in checkClusterCompatibilityFromHeader Dec 28, 2024
@ivanvc
Copy link
Member

ivanvc commented Jan 7, 2025

I agree; from reading the code, it didn't fail to check the version compatibility, but there's a version mismatch.

/ok-to-test

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 68.78%. Comparing base (a37bee0) to head (a1a9149).
Report is 41 commits behind head on main.

Files with missing lines Patch % Lines
server/etcdserver/api/rafthttp/http.go 0.00% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
server/etcdserver/api/rafthttp/http.go 77.34% <0.00%> (ø)

... and 29 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19112      +/-   ##
==========================================
- Coverage   68.79%   68.78%   -0.02%     
==========================================
  Files         420      420              
  Lines       35640    35640              
==========================================
- Hits        24520    24515       -5     
- Misses       9693     9697       +4     
- Partials     1427     1428       +1     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a37bee0...a1a9149. Read the comment docs.

Signed-off-by: adeyemi <[email protected]>
@ivanvc
Copy link
Member

ivanvc commented Jan 8, 2025

/retitle rafthttp: Improve warn message in checkClusterCompatibilityFromHeader

@k8s-ci-robot k8s-ci-robot changed the title rafthttp: Update typo in warn message in checkClusterCompatibilityFromHeader rafthttp: Improve warn message in checkClusterCompatibilityFromHeader Jan 8, 2025
Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @aladesawe.

Just emphasizing my previous comment: #19112 (comment).

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, aladesawe, ivanvc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit 9db8dcb into etcd-io:main Jan 10, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants