-
-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kindergarten-garden (#940) #943
Add kindergarten-garden (#940) #943
Conversation
"status": { | ||
"concept_exercises": false, | ||
"test_runner": true, | ||
"representer": false, | ||
"analyzer": false | ||
}, | ||
"blurb": "C is a small, general-purpose, imperative programming language with a static type system, scopes, and structures. It's typically used as an alternative to assembly programming, such as in operating systems.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bin/configlet create
made those extra changes. Not sure we want to keep them as part of this PR. I can for sure revert them and only keep the addition of the entry for this exercise.
exercises/practice/kindergarten-garden/test_kindergarten_garden.c
Outdated
Show resolved
Hide resolved
exercises/practice/kindergarten-garden/test_kindergarten_garden.c
Outdated
Show resolved
Hide resolved
exercises/practice/kindergarten-garden/test_kindergarten_garden.c
Outdated
Show resolved
Hide resolved
|
||
int main(void) | ||
{ | ||
UnityBegin("test_kindergarten-garden.c"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UnityBegin("test_kindergarten-garden.c"); | |
UnityBegin("test_kindergarten_garden.c"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question for the maintainers: Why do we use UnityBegin
with an explicit filename and UnityEnd
instead of UNITY_BEGIN()
without the filename and UNITY_END()
?
(see https://github.com/ThrowTheSwitch/Unity/blob/master/docs/UnityConfigurationGuide.md#main)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the only project where I've used Unity and it was done like this when I became a maintainer of the track. In other words, I have no idea, and I didn't realize that there was another option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed the name now. You want me to remove it? Another PR could change the existing exercises to make things consistent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ahans another PR to change this would be great.
I hope I addressed all comments now. |
See discussion [here](exercism#943 (review)) Done via: ``` for f in $(find . -name "test_*.c"); do sed -i -e 's/UnityBegin\(.*\);/UNITY_BEGIN();/' $f sed -i -e 's/UnityEnd/UNITY_END/' $f done ```
See discussion [here](exercism#943 (review)) Done via: ``` for f in $(find . -name "test_*.c"); do sed -i -e 's/UnityBegin\(.*\);/UNITY_BEGIN();/' $f sed -i -e 's/UnityEnd/UNITY_END/' $f done ```
See discussion [here](exercism#943 (review)) Done via: ``` for f in $(find . -name "test_*.c"); do sed -i -e 's/UnityBegin\(.*\);/UNITY_BEGIN();/' $f sed -i -e 's/UnityEnd/UNITY_END/' $f done ```
See discussion [here](exercism#943 (review)) Done via: ``` for f in $(find . -name "test_*.c"); do sed -i '' 's/UnityBegin\(.*\);/UNITY_BEGIN();/' $f sed -i '' 's/UnityEnd/UNITY_END/' $f done ```
See discussion [here](exercism#943 (review)) Done via: ``` for f in $(find . -name "test_*.c"); do sed -i '' 's/UnityBegin\(.*\);/UNITY_BEGIN();/' $f sed -i '' 's/UnityEnd/UNITY_END/' $f done ```
See discussion [here](#943 (review)) Done via: ``` for f in $(find . -name "test_*.c"); do sed -i '' 's/UnityBegin\(.*\);/UNITY_BEGIN();/' $f sed -i '' 's/UnityEnd/UNITY_END/' $f done ```
This adds
kindergarten-garden
from #940's list.