Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kindergarten-garden (#940) #943

Merged
merged 2 commits into from
Jan 28, 2024

Conversation

ahans
Copy link
Contributor

@ahans ahans commented Jan 27, 2024

This adds kindergarten-garden from #940's list.

"status": {
"concept_exercises": false,
"test_runner": true,
"representer": false,
"analyzer": false
},
"blurb": "C is a small, general-purpose, imperative programming language with a static type system, scopes, and structures. It's typically used as an alternative to assembly programming, such as in operating systems.",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bin/configlet create made those extra changes. Not sure we want to keep them as part of this PR. I can for sure revert them and only keep the addition of the entry for this exercise.

@ryanplusplus ryanplusplus mentioned this pull request Jan 27, 2024
12 tasks

int main(void)
{
UnityBegin("test_kindergarten-garden.c");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
UnityBegin("test_kindergarten-garden.c");
UnityBegin("test_kindergarten_garden.c");

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question for the maintainers: Why do we use UnityBegin with an explicit filename and UnityEnd instead of UNITY_BEGIN() without the filename and UNITY_END()?
(see https://github.com/ThrowTheSwitch/Unity/blob/master/docs/UnityConfigurationGuide.md#main)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only project where I've used Unity and it was done like this when I became a maintainer of the track. In other words, I have no idea, and I didn't realize that there was another option.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed the name now. You want me to remove it? Another PR could change the existing exercises to make things consistent.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahans another PR to change this would be great.

@ahans
Copy link
Contributor Author

ahans commented Jan 28, 2024

I hope I addressed all comments now.

@ryanplusplus ryanplusplus merged commit 54d0376 into exercism:main Jan 28, 2024
4 checks passed
ahans added a commit to ahans/c that referenced this pull request Jan 28, 2024
See discussion [here](exercism#943 (review))

Done via:
```
for f in $(find . -name "test_*.c"); do
    sed -i -e 's/UnityBegin\(.*\);/UNITY_BEGIN();/' $f
    sed -i -e 's/UnityEnd/UNITY_END/' $f
done
```
ahans added a commit to ahans/c that referenced this pull request Jan 28, 2024
See discussion [here](exercism#943 (review))

Done via:
```
for f in $(find . -name "test_*.c"); do
    sed -i -e 's/UnityBegin\(.*\);/UNITY_BEGIN();/' $f
    sed -i -e 's/UnityEnd/UNITY_END/' $f
done
```
ahans added a commit to ahans/c that referenced this pull request Jan 28, 2024
See discussion [here](exercism#943 (review))

Done via:
```
for f in $(find . -name "test_*.c"); do
    sed -i -e 's/UnityBegin\(.*\);/UNITY_BEGIN();/' $f
    sed -i -e 's/UnityEnd/UNITY_END/' $f
done
```
ahans added a commit to ahans/c that referenced this pull request Jan 28, 2024
See discussion [here](exercism#943 (review))

Done via:
```
for f in $(find . -name "test_*.c"); do
    sed -i '' 's/UnityBegin\(.*\);/UNITY_BEGIN();/' $f
    sed -i '' 's/UnityEnd/UNITY_END/' $f
done
```
ahans added a commit to ahans/c that referenced this pull request Jan 28, 2024
See discussion [here](exercism#943 (review))

Done via:
```
for f in $(find . -name "test_*.c"); do
    sed -i '' 's/UnityBegin\(.*\);/UNITY_BEGIN();/' $f
    sed -i '' 's/UnityEnd/UNITY_END/' $f
done
```
ryanplusplus pushed a commit that referenced this pull request Jan 29, 2024
See discussion [here](#943 (review))

Done via:
```
for f in $(find . -name "test_*.c"); do
    sed -i '' 's/UnityBegin\(.*\);/UNITY_BEGIN();/' $f
    sed -i '' 's/UnityEnd/UNITY_END/' $f
done
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants