Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Force Ubuntu 22.04 for input and query API workflows #223

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nadiiaboichuk
Copy link
Contributor

@nadiiaboichuk nadiiaboichuk commented Jan 9, 2025

Github changed Ubuntu-latest to Ubuntu-24.04. Changing back to 22.04 as Nuget is not available in 24.04.

Copy link
Contributor

@TurcanStanislav TurcanStanislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a suggestion that where we don't use nuget(or other missing dependency in the new ubuntu version) we can continue using latest tag.

@@ -88,7 +88,7 @@ on:

jobs:
test-opa-policies:
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
Copy link
Contributor

@TurcanStanislav TurcanStanislav Jan 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not seem that we use setup-nuget github action nor depend on nuget here. Is there another reason to change it here? The same question for other places.

Copy link
Contributor Author

@nadiiaboichuk nadiiaboichuk Jan 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it makes sense to use the same OS everywhere instead of using one OS for one job and another one for other jobs

@OUeland
Copy link
Contributor

OUeland commented Jan 9, 2025

Have you checked that this expected? A quick glance at the latest vs the older one I did not see nuget mentioned in either of them? I probably missed it, but if this is a bug from GitHub then perhaps we should report it?

@nadiiaboichuk
Copy link
Contributor Author

Have you checked that this expected? A quick glance at the latest vs the older one I did not see nuget mentioned in either of them? I probably missed it, but if this is a bug from GitHub then perhaps we should report it?

According to the description of this issue, nuget is not available on Ubuntu 24.04, also there is another issue. As a workaround let's switch to 22.04. In the long term we should change the workflows so they do not fail on Ubuntu 24.04 (use dotnet nuget and dotnet publish commands, use different container images, etc), will create a Jira issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants