Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better contrast for component grid component header #4431

Merged
merged 2 commits into from
Jan 8, 2025
Merged

Better contrast for component grid component header #4431

merged 2 commits into from
Jan 8, 2025

Conversation

hichemfantar
Copy link
Contributor

@hichemfantar hichemfantar commented Jan 8, 2025 •
edited
Loading

Change the background color of the component grid to enhance the contrast.

before
image

image

after
image

image

@netlify Netlify
Copy link

netlify bot commented Jan 8, 2025 •
edited
Loading

✅ Deploy Preview for react-native ready!

Name Link
🔨 Latest commit 26b925b
🔍 Latest deploy log https://app.netlify.com/sites/react-native/deploys/677e9932e66cdd00084981aa
😎 Deploy Preview https://deploy-preview-4431--react-native.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hichemfantar hichemfantar changed the title Better contrast for component grid item Better contrast for component grid component header Jan 8, 2025
@cortinico cortinico requested a review from Simek January 8, 2025 11:16
@hichemfantar hichemfantar requested a review from Simek January 8, 2025 16:34
Simek
Simek approved these changes Jan 8, 2025
View reviewed changes
Copy link
Collaborator

@Simek Simek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates! 🚀

@Simek Simek merged commit 90073d5 into facebook:main Jan 8, 2025
4 checks passed
@hichemfantar hichemfantar deleted the better-contrast branch January 8, 2025 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Simek Simek Simek approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hichemfantar @Simek @facebook-github-bot