Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CEH gradients #1153

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

CEH gradients #1153

wants to merge 7 commits into from

Conversation

Albkat
Copy link
Member

@Albkat Albkat commented Jan 9, 2025

The implementation of the numerical charge gradients num_grad_chrg (for CEH).
The output is written to ceh.grad.
@lukaswittmann, please be careful with the output format.

@Albkat Albkat requested a review from lukaswittmann January 9, 2025 12:55
@Albkat Albkat added the enhancement New feature or request label Jan 9, 2025
@Albkat Albkat added this to the v6.7.2 milestone Jan 9, 2025
@Albkat
Copy link
Member Author

Albkat commented Jan 9, 2025

The CI failure is due to the missing LAPACK/BLAS libraries in Ubuntu 24.04.1.

It seems to work with Ubuntu 24.04.5 (run)
As the updated runners are still being rolled out, the potential fix might be completed around the end of January.

lukaswittmann
lukaswittmann previously approved these changes Jan 10, 2025
Copy link
Member

@lukaswittmann lukaswittmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your great work, looks good to me.

@lukaswittmann
Copy link
Member

I renamed the file where the ceh numerical gradients are written to for consistency reason.

Signed-off-by: albert <[email protected]>
@Albkat
Copy link
Member Author

Albkat commented Jan 10, 2025

I added the CLI argument description:

--ceh grad [REAL]

to calculate numerical gradients (with an optional step size specification).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants