test: add UT for ListenEndpoint in utils.go #2339
Open
+75
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the
pkg/csi-common/utils.go
andpkg/csi-common/utils_test.go
files to improve error handling and add new tests for theListenEndpoint
function. The most important changes include refactoring the logging mechanism and adding a comprehensive test for theListenEndpoint
function.Improvements to error handling:
pkg/csi-common/utils.go
: Introduced a newklogFatalf
function to replace direct calls toklog.Fatalf
, allowing for better control and testing of fatal log messages.Enhancements to testing:
pkg/csi-common/utils_test.go
: Added a newTestListenEndpoint
function to test various scenarios for theListenEndpoint
function, including handling of Unix and TCP sockets, and invalid endpoints. This function also skips tests on Windows and uses a mockklogFatalf
to prevent actual termination during tests.pkg/csi-common/utils_test.go
: Updated imports to includeos
andruntime
packages, which are required for the new tests.<!-- Thanks for sending a pull request! Here are some tips for you:https://git.k8s.io/community/contributors/devel/release.md#issue-kind-label
-->
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: