Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add VolumeSize parameter for RosaMachinePool #5270

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

✨ Add VolumeSize parameter for RosaMachinePool #5270

wants to merge 1 commit into from
+35 −0

Conversation

PanSpagetka
Copy link

@PanSpagetka PanSpagetka commented Jan 8, 2025 •
edited
Loading

In this MR I am adding VolumeSize parameter for RosaMachinePool. Also I am allowing VolumeSize to be set for default workers machine pool via DefaultMachinePoolSpec. You can set VolumeSize via other ways of creating Rosa cluster(CLI/UI).

What type of PR is this?
/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits
  • includes documentation
  • includes emojis
  • adds unit tests
  • adds or updates e2e tests

Release note:

 Add VolumeSize parameter for RosaMachinePool.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. labels Jan 8, 2025
@k8s-ci-robot k8s-ci-robot requested a review from damdo January 8, 2025 12:52
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign serngawy for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from serngawy January 8, 2025 12:52
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority labels Jan 8, 2025
@PanSpagetka PanSpagetka marked this pull request as draft January 8, 2025 12:52
@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 8, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @PanSpagetka. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@PanSpagetka PanSpagetka changed the title WIP: Add VolumeSize parameter for RosaMachinePool ✨ WIP: Add VolumeSize parameter for RosaMachinePool Jan 8, 2025
serngawy
serngawy reviewed Jan 8, 2025
View reviewed changes
controlplane/rosa/api/v1beta2/rosacontrolplane_types.go Show resolved Hide resolved
controlplane/rosa/controllers/rosacontrolplane_controller.go Outdated
@@ -957,6 +957,10 @@ func buildOCMClusterSpec(controlPlaneSpec rosacontrolplanev1.RosaControlPlaneSpe
ocmClusterSpec.NetworkType = networkSpec.NetworkType
}

if controlPlaneSpec.DefaultMachinePoolSpec.VolumeSize > 0 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better to be VolumeSize > 75 (the min)

@PanSpagetka PanSpagetka changed the title ✨ WIP: Add VolumeSize parameter for RosaMachinePool ✨ Add VolumeSize parameter for RosaMachinePool Jan 8, 2025
@PanSpagetka PanSpagetka marked this pull request as ready for review January 8, 2025 14:38
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 8, 2025
serngawy
serngawy reviewed Jan 8, 2025
View reviewed changes
exp/controllers/rosamachinepool_controller.go Outdated
@@ -473,6 +473,9 @@ func nodePoolBuilder(rosaMachinePoolSpec expinfrav1.RosaMachinePoolSpec, machine
if rosaMachinePoolSpec.AdditionalTags != nil {
awsNodePool = awsNodePool.Tags(rosaMachinePoolSpec.AdditionalTags)
}
if rosaMachinePoolSpec.VolumeSize > 0 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above >= 75

@serngawy
Copy link
Contributor

serngawy commented Jan 8, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serngawy serngawy serngawy left review comments

@damdo damdo Awaiting requested review from damdo

@Ankitasw Ankitasw Awaiting requested review from Ankitasw

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. needs-priority ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PanSpagetka @k8s-ci-robot @serngawy