Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Remove ORC from CAPO #2346

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

EmilienM
Copy link
Contributor

@EmilienM EmilienM commented Dec 30, 2024

This pull request removes the in-tree ORC (OpenStack Resource Controller) integration from the project to use the one that is out of tree.

Removal of ORC Integration:

Go Version Update:

  • Dockerfile: Updated the Go version from 1.22.0 to 1.23.0.
  • go.mod: Updated the Go version and dependencies, and removed the local replace directive for ORC. [1] [2] [3] [4]
  • hack/tools/go.mod: Updated the Go version and dependencies, and removed the local replace directive for ORC. [1] [2] [3] [4]

Deploy ORC for e2e tests

Using CAPI machinery, ORC will be deployed as a RuntimeExtensionProvider.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 30, 2024
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 30, 2024
Copy link

netlify bot commented Dec 30, 2024

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit 10542dd
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/6780783c9d5c890008e1818e
😎 Deploy Preview https://deploy-preview-2346--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@EmilienM
Copy link
Contributor Author

TODO: deploy ORC in e2e

@EmilienM EmilienM force-pushed the orc branch 2 times, most recently from 10febc8 to 31afcc9 Compare December 30, 2024 13:54
@EmilienM
Copy link
Contributor Author

/cc mandre pierreprinetti

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from emilienm. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@EmilienM
Copy link
Contributor Author

EmilienM commented Jan 9, 2025

/test pull-cluster-api-provider-openstack-e2e-full-test

@EmilienM EmilienM force-pushed the orc branch 4 times, most recently from c084cbc to d39c163 Compare January 10, 2025 01:11
@k8s-ci-robot
Copy link
Contributor

@EmilienM: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-openstack-e2e-full-test b3bfade link false /test pull-cluster-api-provider-openstack-e2e-full-test
pull-cluster-api-provider-openstack-e2e-test 10542dd link true /test pull-cluster-api-provider-openstack-e2e-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
Status: Inbox
Development

Successfully merging this pull request may close these issues.

2 participants