Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ clusterctl move support for a cross namespace ClusterClass reference #11649

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

✨ clusterctl move support for a cross namespace ClusterClass reference #11649

wants to merge 13 commits into from

Conversation

Danil-Grigorev
Copy link
Member

@Danil-Grigorev Danil-Grigorev commented Jan 7, 2025 •
edited
Loading

What this PR does / why we need it:

A follow-up on #11352 functionality, which integrates classNamespace field with clusterctl move.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Related to #5673

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign neolit123 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 7, 2025
@k8s-ci-robot k8s-ci-robot requested review from elmiko and enxebre January 7, 2025 21:26
@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-area PR is missing an area label size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 7, 2025
Danil-Grigorev and others added 11 commits January 8, 2025 22:00
@Danil-Grigorev
Add classNamespace to topology
1fb1287 
Signed-off-by: Danil-Grigorev <[email protected]>
@Danil-Grigorev
Add documentation on securing cross-namespace access for CC
d8d4132 
Signed-off-by: Danil-Grigorev <[email protected]>
@Danil-Grigorev
Lookup Clusters across namespaces
80f2faf 
Signed-off-by: Danil-Grigorev <[email protected]>
@Danil-Grigorev
Add a note on cross-ns rebase
0c17213 
Signed-off-by: Danil-Grigorev <[email protected]>
@Danil-Grigorev
Add validation on classNamespace, API review addressed
01bebff 
Signed-off-by: Danil-Grigorev <[email protected]>
@Danil-Grigorev
Add tests for clusterclassToCluster, godoc changes
24bcb75 
Signed-off-by: Danil-Grigorev <[email protected]>
@Danil-Grigorev
Add ClassNamespace index
1b6e9ec 
Signed-off-by: Danil-Grigorev <[email protected]>
@Danil-Grigorev
Clarify cross-namespace rebase support godoc
18b4348 
Signed-off-by: Danil-Grigorev <[email protected]>
@Danil-Grigorev
Use MatchingFields as And logic
81e6316 
Signed-off-by: Danil-Grigorev <[email protected]>
@Danil-Grigorev @chrischdi
Fix spelling
8969890 
Co-authored-by: Christian Schlotter <[email protected]>
@Danil-Grigorev
Make TestClusterClassToCluster independent on request order
f1456bd 
Signed-off-by: Danil-Grigorev <[email protected]>
elmiko
elmiko reviewed Jan 8, 2025
View reviewed changes
Copy link
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this generally makes sense, but i have a couple questions.

also, happy to see the docs update 🙏

api/v1beta1/cluster_types.go
// +kubebuilder:validation:MinLength=1
// +kubebuilder:validation:MaxLength=253
// +kubebuilder:validation:Pattern="^[a-z0-9](?:[-a-z0-9]*[a-z0-9])?(?:\\.[a-z0-9](?:[-a-z0-9]*[a-z0-9])?)*$"
ClassNamespace string `json:"classNamespace,omitempty"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have consensus about adding this field to the API?

i mean, it seems necessary for this change, but i don't recall what we might have agreed upon in the office hours.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s actually a superset of #11352, I believe we have a consensus on the actual PR in the review #11352 (comment) (correct me if I’m wrong)

api/v1beta1/index/cluster.go Outdated
@@ -55,3 +69,12 @@ func ClusterByClusterClassClassName(o client.Object) []string {
}
return nil
}

// ClusterByClusterClassClassNamespace contains the logic to index Clusters by ClusterClass namespace.
func ClusterByClusterClassClassNamespace(o client.Object) []string {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this need the stutter, could we just name it ClusterByClusterClassNamespace ?

or if we need the extra context could we name it something different like ClusterByClusterClassTopologyNamespace ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good catch, I’ll update it. I think ClusterByClusterClassNamespace follows the naming pattern here.

@Danil-Grigorev Danil-Grigorev force-pushed the class-namespace-move-support branch from 41b5c72 to bc1b8fc Compare January 9, 2025 21:05
@Danil-Grigorev Danil-Grigorev force-pushed the class-namespace-move-support branch from bc1b8fc to 8f8f47b Compare January 9, 2025 21:08
@k8s-ci-robot k8s-ci-robot added area/clusterclass Issues or PRs related to clusterclass and removed do-not-merge/needs-area PR is missing an area label labels Jan 9, 2025
elmiko
elmiko reviewed Jan 9, 2025
View reviewed changes
Copy link
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is generally making sense to me, do we need to merge #11352 first?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elmiko elmiko elmiko left review comments

@enxebre enxebre Awaiting requested review from enxebre

Assignees
No one assigned
Labels
area/clusterclass Issues or PRs related to clusterclass cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Danil-Grigorev @k8s-ci-robot @elmiko