Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update 1.33 team leads #8236

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Update 1.33 team leads #8236

wants to merge 4 commits into from

Conversation

npolshakova
Copy link
Contributor

Adds the release team to Slack groups and usergroups for v1.33 cycle as part of kubernetes/sig-release#2705.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 8, 2025
@k8s-ci-robot k8s-ci-robot requested review from jeefy and xmudrii January 8, 2025 21:21
@k8s-ci-robot k8s-ci-robot added area/community-management size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/slack-management Issues or PRs related to the Slack Management subproject sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/release Categorizes an issue or PR as relevant to SIG Release. labels Jan 8, 2025
@npolshakova npolshakova mentioned this pull request Jan 8, 2025
Open
gracenng
gracenng reviewed Jan 8, 2025
View reviewed changes
Copy link
Member

@gracenng gracenng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 8, 2025
@gracenng
Copy link
Member

gracenng commented Jan 8, 2025

/approve

@katcosgrove
Copy link
Contributor

/assign @munnerz

@munnerz
Copy link
Member

munnerz commented Jan 9, 2025

/approve
/hold

In case you have any follow up changes to make 😊

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 9, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gracenng, munnerz, npolshakova

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2025
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 9, 2025
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wendy-ha18 wendy-ha18 wendy-ha18 left review comments

@gracenng gracenng gracenng left review comments

@jeefy jeefy Awaiting requested review from jeefy

@xmudrii xmudrii Awaiting requested review from xmudrii

Assignees

@munnerz munnerz

@gracenng gracenng

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/community-management area/slack-management Issues or PRs related to the Slack Management subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@npolshakova @gracenng @katcosgrove @munnerz @k8s-ci-robot @wendy-ha18