-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chart: Add controller.service.trafficDistribution
.
#12571
Conversation
|
Welcome @aofei! |
Hi @aofei. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for kubernetes-ingress-nginx canceled.
|
/triage accepted Could you please extend the existing unit tests? Thank you! |
1a51fe1
to
63c3306
Compare
|
63c3306
to
18a5bdf
Compare
18a5bdf
to
02f2105
Compare
.spec.trafficDistribution
support for controller servicescontroller.service.trafficDistribution
.
02f2105
to
e41e3f4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/triage accepted
/kind feature
/priority backlog
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aofei, Gacko The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
What this PR does / why we need it:
Add support for
.spec.trafficDistribution
field in controller service configuration to route traffic to endpoints that are topologically closer to the client.Ref: https://kubernetes.io/docs/concepts/services-networking/service/#traffic-distribution
Types of changes
Which issue/s this PR fixes
How Has This Been Tested?
helm unittest .
Checklist: