-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor validation logic around checking for multiple options #17187
base: master
Are you sure you want to change the base?
Conversation
WIP because I want to validate that this detects that the json names aren't yet right in v1alpha3 (also I need to rebase for kindnet) |
6b8ec70
to
7df0636
Compare
7df0636
to
33a1c37
Compare
We also have to move some of the EnvVar handling around to avoid a circular reference.
33a1c37
to
5fa9690
Compare
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
@justinsb: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
We also have to move some of the EnvVar handling around to avoid a circular reference.