Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRA: periodic jobs may run slow tests #34113

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

pohly
Copy link
Contributor

@pohly pohly commented Jan 9, 2025

It's only the presubmits which need to be fast.

/assign @dims
/priority important-soon

I want to be sure that the slow DRA tests don't regress after merging kubernetes/kubernetes#129543.

It's only the presubmits which need to be fast.
@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 9, 2025
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/jobs sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jan 9, 2025
@pohly
Copy link
Contributor Author

pohly commented Jan 9, 2025

/assign @bart0sh

@bart0sh
Copy link
Contributor

bart0sh commented Jan 10, 2025

/lgtm

/assign @dims @kannon92 @SergeyKanzhelev
for approval

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 10, 2025
@pohly
Copy link
Contributor Author

pohly commented Jan 10, 2025

Can we expand the set of approvers for SIG Node jobs so that we have coverage while the US folks are offline?

How about adding @klueska?

@pohly
Copy link
Contributor Author

pohly commented Jan 10, 2025

Oh, he is an approver.

/assign @klueska

@klueska
Copy link

klueska commented Jan 10, 2025

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: klueska, pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2025
@k8s-ci-robot k8s-ci-robot merged commit 00a9ce0 into kubernetes:master Jan 10, 2025
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@pohly: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key dra-ci.yaml using file config/jobs/kubernetes/sig-node/dra-ci.yaml

In response to this:

It's only the presubmits which need to be fast.

/assign @dims
/priority important-soon

I want to be sure that the slow DRA tests don't regress after merging kubernetes/kubernetes#129543.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Development

Successfully merging this pull request may close these issues.

7 participants