Updated node roles in docs #49360
Open
Updated node roles in docs #49360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/XS
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
sftim
reviewed
Jan 8, 2025
| @@ -140,6 +140,8 @@ When you want to create Node objects manually, set the kubelet flag `--register- | |||
| You can modify Node objects regardless of the setting of `--register-node`. | |||
| For example, you can set labels on an existing Node or mark it unschedulable. | |||
|
|
|||
| You can set optional node role for nodes by adding `node-role.kubernetes.io/<role>=` label to the node where characters of `<role>` are limited by the [syntax](https://kubernetes.io/docs/concepts/overview/working-with-objects/labels/#syntax-and-character-set) rules of labels. | |||
There was a problem hiding this comment.
Does this look right?
Suggested change
| You can set optional node role for nodes by adding `node-role.kubernetes.io/<role>=` label to the node where characters of `<role>` are limited by the [syntax](https://kubernetes.io/docs/concepts/overview/working-with-objects/labels/#syntax-and-character-set) rules of labels. | |
| You can set optional node role(s) for nodes by adding one or more `node-role.kubernetes.io/<role>: <role>` labels to the node | |
| where the characters of `<role>` are limited by the | |
| [syntax](/docs/concepts/overview/working-with-objects/labels/#syntax-and-character-set) rules for labels. | |
| Kubernetes ignores the label value for node roles; by convention, you set it to the same string you used | |
| for the node role in the label key. |
There was a problem hiding this comment.
We ought to add an entry for node-role.kubernetes.io/* (as well as the specific control plane role).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #48803