Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change <url> to url() and link to Web/CSS/url_function #25582

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Jan 6, 2025

Summary

Changes the description of css.types.url from <url> (type) to url() (function), and links css.types.url and css.properties.content.url to Web/CSS/url_function.

Also adds a missing description to css.properties.list-style-type.symbols.

Test results and supporting details

Related issues

Fixes #25413.

@github-actions github-actions bot added data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS size:s [PR only] 7-24 LoC changed labels Jan 6, 2025
@@ -3,8 +3,8 @@
"types": {
"url": {
"__compat": {
"description": "`&lt;url&gt;`",
"mdn_url": "https://developer.mozilla.org/docs/Web/CSS/url_value",
"description": "`url()`",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, but this is about <url>, right?

From #25413, I see <url> = <url()> | <src()>. So, this file at some point will have entries like this:

  • css types.url (<url>)
  • css.types.url.url (url())
  • css.types.url.src (src())

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this feature was about the <url> type, then shouldn't it have partial_implementation? The way I see it this feature currently only shows the support for url(), not <url>. And url() is likely more useful than <url> from a reader's point of view.

Note that #25081 proposed to add a src subfeature, but the only browser bug (https://bugzilla.mozilla.org/show_bug.cgi?id=1707923) did not suggest that this will be implemented anytime soon.

@github-actions github-actions bot added the merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. label Jan 8, 2025
Copy link

github-actions bot commented Jan 8, 2025

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot removed the merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. label Jan 8, 2025
css/types/url.json Outdated Show resolved Hide resolved
@github-actions github-actions bot added size:xs [PR only] 0-6 LoC changed and removed size:s [PR only] 7-24 LoC changed labels Jan 8, 2025
@caugner caugner requested a review from Elchi3 January 9, 2025 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS size:xs [PR only] 0-6 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mismatch bcd key for url() function
2 participants