-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change <url>
to url()
and link to Web/CSS/url_function
#25582
base: main
Are you sure you want to change the base?
Conversation
@@ -3,8 +3,8 @@ | |||
"types": { | |||
"url": { | |||
"__compat": { | |||
"description": "`<url>`", | |||
"mdn_url": "https://developer.mozilla.org/docs/Web/CSS/url_value", | |||
"description": "`url()`", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm, but this is about <url>
, right?
From #25413, I see <url> = <url()> | <src()>
. So, this file at some point will have entries like this:
- css types.url (
<url>
) - css.types.url.url (
url()
) - css.types.url.src (
src()
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this feature was about the <url>
type, then shouldn't it have partial_implementation
? The way I see it this feature currently only shows the support for url()
, not <url>
. And url()
is likely more useful than <url>
from a reader's point of view.
Note that #25081 proposed to add a src
subfeature, but the only browser bug (https://bugzilla.mozilla.org/show_bug.cgi?id=1707923) did not suggest that this will be implemented anytime soon.
This pull request has merge conflicts that must be resolved before it can be merged. |
Summary
Changes the description of
css.types.url
from<url>
(type) tourl()
(function), and linkscss.types.url
andcss.properties.content.url
to Web/CSS/url_function.Also adds a missing description to
css.properties.list-style-type.symbols
.Test results and supporting details
Related issues
Fixes #25413.