fix bug (#78)

microsoft · Jan 8, 2025 · f247557 · f247557
1 parent add9e26
commit f247557
Show file tree

Hide file tree

Showing 8 changed files with 196 additions and 180 deletions.
diff --git a/sdk/feature-management/.eslintrc b/sdk/feature-management/.eslintrc
@@ -33,6 +33,13 @@
         "@typescript-eslint"
     ],
     "rules": {
+        "keyword-spacing": [
+            "error",
+            {
+                "before": true,
+                "after": true
+            }
+        ],
         "quotes": [
             "error",
             "double",

diff --git a/sdk/feature-management/package-lock.json b/sdk/feature-management/package-lock.json
diff --git a/sdk/feature-management/src/featureProvider.ts b/sdk/feature-management/src/featureProvider.ts
@@ -36,9 +36,11 @@ export class ConfigurationMapFeatureFlagProvider implements IFeatureFlagProvider
 
     async getFeatureFlags(): Promise<FeatureFlag[]> {
         const featureConfig = this.#configuration.get<FeatureManagementConfiguration>(FEATURE_MANAGEMENT_KEY);
-        const featureFlag = featureConfig?.[FEATURE_FLAGS_KEY] ?? [];
-        validateFeatureFlag(featureFlag);
-        return featureFlag;
+        const featureFlags = featureConfig?.[FEATURE_FLAGS_KEY] ?? [];
+        featureFlags.forEach(featureFlag => {
+            validateFeatureFlag(featureFlag);
+        });
+        return featureFlags;
     }
 }
 
@@ -60,8 +62,10 @@ export class ConfigurationObjectFeatureFlagProvider implements IFeatureFlagProvi
     }
 
     async getFeatureFlags(): Promise<FeatureFlag[]> {
-        const featureFlag = this.#configuration[FEATURE_MANAGEMENT_KEY]?.[FEATURE_FLAGS_KEY] ?? [];
-        validateFeatureFlag(featureFlag);
-        return featureFlag;
+        const featureFlags = this.#configuration[FEATURE_MANAGEMENT_KEY]?.[FEATURE_FLAGS_KEY] ?? [];
+        featureFlags.forEach(featureFlag => {
+            validateFeatureFlag(featureFlag);
+        });
+        return featureFlags;
     }
 }
diff --git a/sdk/feature-management/src/filter/TargetingFilter.ts b/sdk/feature-management/src/filter/TargetingFilter.ts
@@ -30,7 +30,7 @@ export class TargetingFilter implements IFeatureFilter {
 
     async evaluate(context: TargetingFilterEvaluationContext, appContext?: ITargetingContext): Promise<boolean> {
         const { featureName, parameters } = context;
-        TargetingFilter.#validateParameters(parameters);
+        TargetingFilter.#validateParameters(featureName, parameters);
 
         if (appContext === undefined) {
             throw new Error("The app context is required for targeting filter.");
@@ -79,15 +79,15 @@ export class TargetingFilter implements IFeatureFilter {
         return isTargetedPercentile(appContext?.userId, hint, 0, parameters.Audience.DefaultRolloutPercentage);
     }
 
-    static #validateParameters(parameters: TargetingFilterParameters): void {
+    static #validateParameters(featureName: string, parameters: TargetingFilterParameters): void {
         if (parameters.Audience.DefaultRolloutPercentage < 0 || parameters.Audience.DefaultRolloutPercentage > 100) {
-            throw new Error("Audience.DefaultRolloutPercentage must be a number between 0 and 100.");
+            throw new Error(`Invalid feature flag: ${featureName}. Audience.DefaultRolloutPercentage must be a number between 0 and 100.`);
         }
         // validate RolloutPercentage for each group
         if (parameters.Audience.Groups !== undefined) {
             for (const group of parameters.Audience.Groups) {
                 if (group.RolloutPercentage < 0 || group.RolloutPercentage > 100) {
-                    throw new Error(`RolloutPercentage of group ${group.Name} must be a number between 0 and 100.`);
+                    throw new Error(`Invalid feature flag: ${featureName}. RolloutPercentage of group ${group.Name} must be a number between 0 and 100.`);
                 }
             }
         }