Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

initialize project with basic feature management support #1

Merged
merged 14 commits into from
Mar 27, 2024
Merged

initialize project with basic feature management support #1

merged 14 commits into from
Mar 27, 2024

Conversation

Eskibear
Copy link
Member

No description provided.

@Eskibear Eskibear marked this pull request as ready for review March 6, 2024 07:39
zhiyuanliang-ms
zhiyuanliang-ms reviewed Mar 6, 2024
View reviewed changes
src/model.ts Outdated Show resolved Hide resolved
mrm9084
mrm9084 requested changes Mar 7, 2024
View reviewed changes
src/featureManager.ts Outdated Show resolved Hide resolved
src/featureManager.ts Show resolved Hide resolved
src/featureManager.ts Outdated Show resolved Hide resolved
src/featureManager.ts Outdated Show resolved Hide resolved
src/featureManager.ts Outdated Show resolved Hide resolved
src/model.ts Show resolved Hide resolved
@mrm9084
Copy link
Contributor

mrm9084 commented Mar 7, 2024

@Eskibear is expected that files don't end in a new line? Have you setup a formatter for this yet?

@Eskibear
Copy link
Member Author

Eskibear commented Mar 8, 2024

@Eskibear is expected that files don't end in a new line? Have you setup a formatter for this yet?

Good catch. I'll add eol-last rule in eslint config file.

@zhiyuanliang-ms zhiyuanliang-ms mentioned this pull request Mar 11, 2024
Merged
@Eskibear Eskibear mentioned this pull request Mar 14, 2024
Open
@Eskibear
Copy link
Member Author

@zhiyuanliang-ms @mrm9084
All above comments are resolved. Do you have any further comment, or we get this init PR merged?

@Eskibear Eskibear merged commit 00d613c into main Mar 27, 2024
1 check passed
@Eskibear Eskibear deleted the yanzh/init branch March 27, 2024 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhiyuanliang-ms zhiyuanliang-ms zhiyuanliang-ms approved these changes

@mrm9084 mrm9084 mrm9084 approved these changes

@avanigupta avanigupta Awaiting requested review from avanigupta

@rossgrambo rossgrambo Awaiting requested review from rossgrambo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Eskibear @mrm9084 @zhiyuanliang-ms