FIX: Tasks on MacOS agents not completing but marked as succeeded.

src/Agent.Sdk/ProcessInvoker.cs

@@ -404,6 +404,11 @@ protected virtual void Dispose(bool disposing)
             {
                 if (_proc != null)
                 {
+                    //Dispose the standard input/output/error stream. Refer: https://github.com/dotnet/runtime/issues/58872
+                    _proc.StandardInput.Dispose();
+                    _proc.StandardOutput.Dispose();
+                    _proc.StandardError.Dispose();
+
                     _proc.Dispose();
                     _proc = null;
                 }

src/Agent.Worker/ResourceMetricsManager.cs

@@ -50,6 +50,7 @@ public sealed class ResourceMetricsManager : AgentService, IResourceMetricsManag
         #region MetricStructs
         private struct CpuInfo
         {
+            public bool IsProcRunning;
             public DateTime Updated;
             public double Usage;
         }
@@ -64,6 +65,7 @@ private struct DiskInfo
 
         public struct MemoryInfo
         {
+            public bool IsProcRunning;
             public DateTime Updated;
             public long TotalMemoryMB;
             public long UsedMemoryMB;
@@ -181,38 +183,57 @@ await Task.Run(() =>
             }
             if (PlatformUtil.RunningOnMacOS)
             {
-                using var processInvoker = HostContext.CreateService<IProcessInvoker>();
-
-                List<string> outputs = new List<string>();
-                processInvoker.OutputDataReceived += delegate (object sender, ProcessDataReceivedEventArgs message)
+                lock (_cpuInfoLock)
                 {
-                    outputs.Add(message.Data);
-                };
+                    if (_cpuInfo.IsProcRunning)
+                    {
+                        return;
+                    }
+                    _cpuInfo.IsProcRunning = true;
+                }
 
-                processInvoker.ErrorDataReceived += delegate (object sender, ProcessDataReceivedEventArgs message)
+                try
                 {
-                    Trace.Error($"Error on receiving CPU info: {message.Data}");
-                };
+                    using var processInvoker = HostContext.CreateService<IProcessInvoker>();
+
+                    List<string> outputs = new List<string>();
+                    processInvoker.OutputDataReceived += delegate (object sender, ProcessDataReceivedEventArgs message)
+                    {
+                        outputs.Add(message.Data);
+                    };
 
-                var filePath = "/bin/bash";
-                var arguments = "-c \"top -l 2 -o cpu | grep ^CPU\"";
-                await processInvoker.ExecuteAsync(
-                        workingDirectory: string.Empty,
-                        fileName: filePath,
-                        arguments: arguments,
-                        environment: null,
-                        requireExitCodeZero: true,
-                        outputEncoding: null,
-                        killProcessOnCancel: true,
-                        cancellationToken: cancellationToken);
-
-                // Use second sample for more accurate calculation
-                var cpuInfoIdle = double.Parse(outputs[1].Split(' ', (char)StringSplitOptions.RemoveEmptyEntries)[6].Trim('%'));
+                    processInvoker.ErrorDataReceived += delegate (object sender, ProcessDataReceivedEventArgs message)
+                    {
+                        Trace.Error($"Error on receiving CPU info: {message.Data}");
+                    };
+
+                    var filePath = "/bin/bash";
+                    var arguments = "-c \"top -l 2 -o cpu | grep ^CPU\"";
+
+                    await processInvoker.ExecuteAsync(
+                            workingDirectory: string.Empty,
+                            fileName: filePath,
+                            arguments: arguments,
+                            environment: null,
+                            requireExitCodeZero: true,
+                            outputEncoding: null,
+                            killProcessOnCancel: true,
+                            cancellationToken: cancellationToken);
+                    // Use second sample for more accurate calculation
+                    var cpuInfoIdle = double.Parse(outputs[1].Split(' ', (char)StringSplitOptions.RemoveEmptyEntries)[6].Trim('%'));
 
-                lock (_cpuInfoLock)
+                    lock (_cpuInfoLock)
+                    {
+                        _cpuInfo.Updated = DateTime.Now;
+                        _cpuInfo.Usage = 100 - cpuInfoIdle;
+                    }
+                }
+                finally
                 {
-                    _cpuInfo.Updated = DateTime.Now;
-                    _cpuInfo.Usage = 100 - cpuInfoIdle;
+                    lock (_cpuInfoLock)
+                    {
+                        _cpuInfo.IsProcRunning = false;
+                    }
                 }
             }
         }
@@ -287,51 +308,71 @@ await Task.Run(() =>
 
             if (PlatformUtil.RunningOnMacOS)
             {
-                // vm_stat allows to get the most detailed information about memory usage on MacOS
-                // but unfortunately it returns values in pages and has no built-in arguments for custom output
-                // so we need to parse and cast the output manually
-
-                using var processInvoker = HostContext.CreateService<IProcessInvoker>();
-
-                List<string> outputs = new List<string>();
-                processInvoker.OutputDataReceived += delegate (object sender, ProcessDataReceivedEventArgs message)
+                lock (_memoryInfoLock)
                 {
-                    outputs.Add(message.Data);
-                };
+                    if (_memoryInfo.IsProcRunning)
+                    {
+                        return;
+                    }
+                    _memoryInfo.IsProcRunning = true;
+                }
 
-                processInvoker.ErrorDataReceived += delegate (object sender, ProcessDataReceivedEventArgs message)
+                try
                 {
-                    Trace.Error($"Error on receiving memory info: {message.Data}");
-                };
+                    // vm_stat allows to get the most detailed information about memory usage on MacOS
+                    // but unfortunately it returns values in pages and has no built-in arguments for custom output
+                    // so we need to parse and cast the output manually
 
-                var filePath = "vm_stat";
-                await processInvoker.ExecuteAsync(
-                        workingDirectory: string.Empty,
-                        fileName: filePath,
-                        arguments: string.Empty,
-                        environment: null,
-                        requireExitCodeZero: true,
-                        outputEncoding: null,
-                        killProcessOnCancel: true,
-                        cancellationToken: cancellationToken);
-
-                var pageSize = int.Parse(outputs[0].Split(" ", StringSplitOptions.RemoveEmptyEntries)[7]);
-
-                var pagesFree = long.Parse(outputs[1].Split(" ", StringSplitOptions.RemoveEmptyEntries)[2].Trim('.'));
-                var pagesActive = long.Parse(outputs[2].Split(" ", StringSplitOptions.RemoveEmptyEntries)[2].Trim('.'));
-                var pagesInactive = long.Parse(outputs[3].Split(" ", StringSplitOptions.RemoveEmptyEntries)[2].Trim('.'));
-                var pagesSpeculative = long.Parse(outputs[4].Split(" ", StringSplitOptions.RemoveEmptyEntries)[2].Trim('.'));
-                var pagesWiredDown = long.Parse(outputs[6].Split(" ", StringSplitOptions.RemoveEmptyEntries)[3].Trim('.'));
-                var pagesOccupied = long.Parse(outputs[16].Split(" ", StringSplitOptions.RemoveEmptyEntries)[4].Trim('.'));
-
-                var freeMemory = (pagesFree + pagesInactive) * pageSize;
-                var usedMemory = (pagesActive + pagesSpeculative + pagesWiredDown + pagesOccupied) * pageSize;
+                    using var processInvoker = HostContext.CreateService<IProcessInvoker>();
 
-                lock (_memoryInfoLock)
+                    List<string> outputs = new List<string>();
+                    processInvoker.OutputDataReceived += delegate (object sender, ProcessDataReceivedEventArgs message)
+                    {
+                        outputs.Add(message.Data);
+                    };
+
+                    processInvoker.ErrorDataReceived += delegate (object sender, ProcessDataReceivedEventArgs message)
+                    {
+                        Trace.Error($"Error on receiving memory info: {message.Data}");
+                    };
+
+                    var filePath = "vm_stat";
+
+                    await processInvoker.ExecuteAsync(
+                            workingDirectory: string.Empty,
+                            fileName: filePath,
+                            arguments: string.Empty,
+                            environment: null,
+                            requireExitCodeZero: true,
+                            outputEncoding: null,
+                            killProcessOnCancel: true,
+                            cancellationToken: cancellationToken);
+
+                    var pageSize = int.Parse(outputs[0].Split(" ", StringSplitOptions.RemoveEmptyEntries)[7]);
+
+                    var pagesFree = long.Parse(outputs[1].Split(" ", StringSplitOptions.RemoveEmptyEntries)[2].Trim('.'));
+                    var pagesActive = long.Parse(outputs[2].Split(" ", StringSplitOptions.RemoveEmptyEntries)[2].Trim('.'));
+                    var pagesInactive = long.Parse(outputs[3].Split(" ", StringSplitOptions.RemoveEmptyEntries)[2].Trim('.'));
+                    var pagesSpeculative = long.Parse(outputs[4].Split(" ", StringSplitOptions.RemoveEmptyEntries)[2].Trim('.'));
+                    var pagesWiredDown = long.Parse(outputs[6].Split(" ", StringSplitOptions.RemoveEmptyEntries)[3].Trim('.'));
+                    var pagesOccupied = long.Parse(outputs[16].Split(" ", StringSplitOptions.RemoveEmptyEntries)[4].Trim('.'));
+
+                    var freeMemory = (pagesFree + pagesInactive) * pageSize;
+                    var usedMemory = (pagesActive + pagesSpeculative + pagesWiredDown + pagesOccupied) * pageSize;
+
+                    lock (_memoryInfoLock)
+                    {
+                        _memoryInfo.Updated = DateTime.Now;
+                        _memoryInfo.TotalMemoryMB = (freeMemory + usedMemory) / 1048576;
+                        _memoryInfo.UsedMemoryMB = usedMemory / 1048576;
+                    }
+                }
+                finally
                 {
-                    _memoryInfo.Updated = DateTime.Now;
-                    _memoryInfo.TotalMemoryMB = (freeMemory + usedMemory) / 1048576;
-                    _memoryInfo.UsedMemoryMB = usedMemory / 1048576;
+                    lock (_memoryInfoLock)
+                    {
+                        _memoryInfo.IsProcRunning = false;
+                    }
                 }
             }
         }

src/Agent.Worker/StepsRunner.cs

@@ -88,8 +88,8 @@ public async Task RunAsync(IExecutionContext jobContext, IList<IStep> steps)
                 }
 
                 // Change the current job context to the step context.
-                var resourceDiagnosticManager = HostContext.GetService<IResourceMetricsManager>();
-                resourceDiagnosticManager.SetContext(step.ExecutionContext);
+                // var resourceDiagnosticManager = HostContext.GetService<IResourceMetricsManager>();
+                // resourceDiagnosticManager.SetContext(step.ExecutionContext);
 
                 // Variable expansion.
                 step.ExecutionContext.SetStepTarget(step.Target);