Remove session cookies when opt-out #568
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
|
This code has been generated on my personal time / with my personal laptop |
AbdelrhmanMagdy
approved these changes
Jun 27, 2024
|
@AbdelrhmanMagdy I saw that you approved this PR but its still missing another approval from Clarity team. Any chance you push forward this PR for another review ? At the moment, we have to have the clarity script locally hosted with the custom code that has been added in this PR in order to remain GDPR compliant, and we are missing out the new bug-fixes / releases due this :) Thanks in advance :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the session cookies, instead of rewriting them with
-Number.MAX_VALUE+Empty value.This previously was causing that the date generated was "Invalid date" and therefore, the cookie was remaining in the browser instead of being reased.
This can be seen in the bug I opened previously #567