Add error reason for control plane out of range. #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mchen727
requested review from
nwoodmsft,
zawachte and
pradipd
as code owners
mchen727
force-pushed
the
user/matthewchen/lb-vip-outofrange
branch
from
9b26d4f to
516f1be
Compare
mchen727
force-pushed
the
user/matthewchen/lb-vip-outofrange
branch
from
c8a7528 to
3e841ea
Compare
madhanrm
reviewed
Jan 29, 2024
| @@ -370,3 +380,39 @@ func (r *AzureStackHCILoadBalancerReconciler) reconcileStatus(lbs *scope.LoadBal | |||
|
|
|||
| lbs.SetPhase(infrav1.AzureStackHCILoadBalancerPhaseProvisioned) | |||
| } | |||
|
|
|||
| func (r *AzureStackHCILoadBalancerReconciler) reconcileLoadBalancerVIP(lbs *scope.LoadBalancerScope, clusterScope *scope.ClusterScope) error { | |||
There was a problem hiding this comment.
can we find out what would happening when Arc Vnets is used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verify that the LB VIP in within the VIP pool range.
Propagates an error through
LoadBalancerInfrastructureReadyConditionif the ip is out of range viaLoadBalancerVIPOutOfRangeReason.