Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/plugins generate #5245

Merged
merged 1 commit into from
Aug 26, 2024
Merged

fix/plugins generate #5245

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions src/kiota/Handlers/Plugin/GenerateHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,7 @@ public override async Task<int> InvokeAsync(InvocationContext context)
var result = await builder.GeneratePluginAsync(cancellationToken).ConfigureAwait(false);
if (result)
{
DisplaySuccess($"Update of {clientEntry.Key} client completed");
var manifestPath = $"{GetAbsolutePath(Path.Combine(WorkspaceConfigurationStorageService.KiotaDirectorySegment, WorkspaceConfigurationStorageService.ManifestFileName))}#{clientEntry.Key}";
DisplayInfoHint(generationConfiguration.Language, string.Empty, manifestPath);
DisplaySuccess($"Update of {clientEntry.Key} plugin completed");
}
else
{
Expand All @@ -76,10 +74,10 @@ public override async Task<int> InvokeAsync(InvocationContext context)
catch (Exception ex)
{
#if DEBUG
logger.LogCritical(ex, "error adding the client: {exceptionMessage}", ex.Message);
logger.LogCritical(ex, "error adding the client: {ExceptionMessage}", ex.Message);
throw; // so debug tools go straight to the source of the exception when attached
#else
logger.LogCritical("error adding the client: {exceptionMessage}", ex.Message);
logger.LogCritical("error adding the client: {ExceptionMessage}", ex.Message);
return 1;
#endif
}
Expand Down
Loading