Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python] Remove deprecated type aliases from generated code for python 3.9+. #5974

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

andrueastman
Copy link
Member

Partial of microsoft/kiota-python#349

Related to microsoft/kiota-python#433

Drops deprecated type hints used in python 3.9+.

@andrueastman
Copy link
Member Author

Sample generation at #5974

@andrueastman
Copy link
Member Author

Depends on release of microsoft/kiota-python#433

@andrueastman andrueastman changed the title Remove deprecated type aliases from generated code. [Python] Remove deprecated type aliases from generated code for python 3.9+. Jan 9, 2025
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly good with those changes. I did leave a comment on the test generation PR. I think a regression was introduced some time ago. Not sure whether we want to address it now or as part of a separate PR.

@@ -16,6 +16,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Fixed a bug in generation when a referenced schema in an allOf was a primitive [#5701](https://github.com/microsoft/kiota/issues/5701).
- Fixed a bug where inherited error models would be missing interface declarations. [#5888](https://github.com/microsoft/kiota/issues/5888)
- Fixed a bug where oneOf/anyOf schemas with single references to inheritance or intersections would be missing properties. [#5921](https://github.com/microsoft/kiota/issues/5921)
- Drops Python 3.8 support by removing deprecated type aliases from generated code. [microsoft/kiota-python#349](https://github.com/microsoft/kiota-python/issues/349)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after the release, this needs to be moved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress 🚧
Development

Successfully merging this pull request may close these issues.

2 participants